feat(driver): drop completed RawOp on Proactor dropping - #167
Merged
Conversation
Berrysoft
added
enhancement
George-Miao
requested changes
Dec 5, 2023
Berrysoft
marked this pull request as draft
December 5, 2023 17:46
Berrysoft
marked this pull request as ready for review
December 6, 2023 16:14
Member
Author
|
When a op is cancelled, the RawOp will be marked |
Berrysoft
force-pushed
the
dev/rawop-drop
branch
from
December 6, 2023 16:16
f210287 to
314b84a
Compare
if the future is dropped. It's a manual Rc. A RawOp will be dropped if it is both completed and cancelled.
Berrysoft
force-pushed
the
dev/rawop-drop
branch
from
December 12, 2023 07:51
eb5d477 to
293d5a3
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164
This PR records a flag in
RawOp. It is set when polling the proactor.