bench(cyper-axum): keep per-connection samples meaningful - #71
Merged
Merged
Conversation
Berrysoft
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round trips were split across connections, so deep cells measured connection ramp-up instead of steady state — at 256 connections each one only got 32 samples, too few for a tail percentile. Adds a floor of 100 per connection and a
16 KiB × 256cell, which is where the buffered path starts to degrade.Existing cells already exceed the floor and are unchanged. Runtime goes from 4.5 s to 5.5 s.
The floor does not make every column stable: axum at
16 KiB × 256still varies several-fold between runs even with 500 samples each, so that appears to be real behaviour rather than a sampling artefact.