fix: harden workflow error matching and input validation - #193
Merged
marcusburghardt merged 2 commits intoJul 30, 2026
Conversation
marcusburghardt
requested review from
gxmiranda,
jflowers and
jpower432
as code owners
July 30, 2026 07:41
marcusburghardt
enabled auto-merge (rebase)
July 30, 2026 08:06
Narrow the error guard from a broad 'check_suite' substring match to the exact upstream error message: "Cannot read properties of undefined (reading 'check_suite')". This prevents accidentally swallowing an unrelated error whose message happens to contain that substring. Addresses review feedback from @gxmiranda on PR complytime#186. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add input validation for ENTERPRISE_MEMBERS_IGNORE values before they are used to build a grep -vE pattern. GitHub usernames only allow [a-zA-Z0-9-], so the values are safe for regex without escaping, but this guard fails fast if an invalid value is ever added -- preventing unexpected regex behavior. Addresses review feedback from @gxmiranda on PR complytime#182. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
fix/workflow-hardening
branch
from
July 30, 2026 08:09
7f1a8ce to
5702230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small hardening improvements addressing review feedback from @gxmiranda.
1. Tighten
check_suiteerror matching (safe-settings sync)Source: PR #186 review
Narrows the error guard from a broad
check_suitesubstring match to theexact upstream error message:
This prevents accidentally swallowing an unrelated error whose message
happens to contain that substring.
2. Validate
ENTERPRISE_MEMBERS_IGNOREusernames (peribolos drift)Source: PR #182 review
Adds input validation for
ENTERPRISE_MEMBERS_IGNOREvalues before theyare used to build a
grep -vEpattern. GitHub usernames only allow[a-zA-Z0-9-], so the values are currently safe for regex withoutescaping. This guard fails fast if an invalid value is ever added,
preventing unexpected regex behavior.