Skip to content

Increase test coverage #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compnerd merged 4 commits into from
Jul 28, 2026
Merged

Increase test coverage #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0929da
GHA: don't let grep swallow crash output as binary
compnerd Jul 28, 2026
106e18b
Testing: drop confirmed-passing entries from ds2 exclusion lists
compnerd Jul 28, 2026
174a175
Testing: re-exclude test_Hc_then_Csignal_signals_correct_thread_launch
compnerd Jul 28, 2026
3974786
Testing: re-exclude flaky/non-ds2 failures surfaced by the fresh prun…
compnerd Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/run-lldb-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,4 @@ runs:
--excluded "$excluded_dir/ds2/${{ inputs.platform }}-${{ inputs.arch }}.excluded" \
--excluded "$excluded_dir/upstream/non-debugserver-tests.excluded" \
-v \
${{ inputs.test-subdirs }} 2>&1 | grep -v '^UNSUPPORTED: LLDB '
${{ inputs.test-subdirs }} 2>&1 | grep -a -v '^UNSUPPORTED: LLDB '
4 changes: 2 additions & 2 deletions .github/workflows/test-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
-v
${{ steps.test-subdirs.outputs.dirs }}
1>/dev/null 2>/tmp/dotest-android-x86_64.log;
rc=$?; grep -v '^UNSUPPORTED: LLDB ' /tmp/dotest-android-x86_64.log; exit $rc
rc=$?; grep -a -v '^UNSUPPORTED: LLDB ' /tmp/dotest-android-x86_64.log; exit $rc

# Run a small sub-set of tests on arm64. The emulator is very slow so it is
# not practical to run more tests until we can run on an arm64 runner with
Expand Down Expand Up @@ -220,4 +220,4 @@ jobs:
SourceCache/llvm/lldb/test/API/linux
SourceCache/llvm/lldb/test/API/sanity
1>/dev/null 2>/tmp/dotest-android-arm64-v8a.log;
rc=$?; grep -v '^UNSUPPORTED: LLDB ' /tmp/dotest-android-arm64-v8a.log; exit $rc
rc=$?; grep -a -v '^UNSUPPORTED: LLDB ' /tmp/dotest-android-arm64-v8a.log; exit $rc
13 changes: 1 addition & 12 deletions Support/Testing/Excluded/ds2/android-x86_64.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,11 @@ TestConcurrentSignalWatch.ConcurrentSignalWatch.test
TestConcurrentTwoBreakpointsOneSignal.ConcurrentTwoBreakpointsOneSignal.test
TestCreateAfterAttach.CreateAfterAttachTestCase.test_create_after_attach_dwarf
TestCreateAfterAttach.CreateAfterAttachTestCase.test_create_after_attach_dwo
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwarf
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwo
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwarf
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwo
TestExec.ExecTestCase.test_correct_thread_plan_state_before_exec
TestExec.ExecTestCase.test_hitting_exec
TestExec.ExecTestCase.test_skipping_exec
TestExprDoesntBlock.ExprDoesntDeadlockTestCase.test_with_run_command_dwarf
TestExprDoesntBlock.ExprDoesntDeadlockTestCase.test_with_run_command_dwo
TestExpressionInSyscall.ExprSyscallTestCase.test_setpgid_dwarf
TestExpressionInSyscall.ExprSyscallTestCase.test_setpgid_dwo
TestFindInMemory.FindInMemoryTestCase.test_find_in_memory_ok
Expand Down Expand Up @@ -77,14 +73,11 @@ TestGdbRemoteThreadsInStopReply.TestGdbRemoteThreadsInStopReply.test_stop_reply_
TestHelloWorld.HelloWorldTestCase.test_with_attach_to_process_with_name_api
TestInferiorCrashing.CrashingInferiorTestCase.test_inferior_crashing_dwarf
TestInferiorCrashing.CrashingInferiorTestCase.test_inferior_crashing_dwo
TestLldbGdbServer.LldbGdbServerTestCase.test_Hc_then_Csignal_signals_correct_thread_launch_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hc_then_Csignal_signals_correct_thread_launch
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_another_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_minus_one_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_zero_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_switches_to_3_threads_launch_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_heap_address_as_rw_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_stack_address_as_rw_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_contains_avx_registers_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_fork_events_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_siginfo_read_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_vfork_events_llgs
Expand Down Expand Up @@ -122,10 +115,7 @@ TestSendSignal.SendSignalTestCase.test_with_run_command_dwarf
TestSendSignal.SendSignalTestCase.test_with_run_command_dwo
TestSettings.SettingsCommandTestCase.test_launchsimple_args_and_env_vars
TestSettings.SettingsCommandTestCase.test_run_args_and_env_vars
TestSingleThreadStepTimeout.SingleThreadStepTimeoutTestCase.test_step_over_deadlock_large_timeout_fast_stepping
TestSingleThreadStepTimeout.SingleThreadStepTimeoutTestCase.test_step_over_deadlock_large_timeout_slow_stepping
TestSingleThreadStepTimeout.SingleThreadStepTimeoutTestCase.test_step_over_deadlock_small_timeout_fast_stepping
TestSingleThreadStepTimeout.SingleThreadStepTimeoutTestCase.test_step_over_deadlock_small_timeout_slow_stepping
TestStateAfterExpression.TestStopReasonAfterExpression.test_thread_state_after_expr_dwarf
TestStateAfterExpression.TestStopReasonAfterExpression.test_thread_state_after_expr_dwo
TestSyntheticCapping.SyntheticCappingTestCase.test_with_run_command_dwo
Expand All @@ -134,7 +124,6 @@ TestTargetCreateDeps.TargetDependentsTestCase.test_dependents_explicit_false_exe
TestTargetCreateDeps.TargetDependentsTestCase.test_dependents_explicit_false_lib
TestTargetCreateDeps.TargetDependentsTestCase.test_dependents_implicit_default_exe
TestTargetCreateDeps.TargetDependentsTestCase.test_dependents_implicit_default_lib
TestThreadStates.ThreadStateTestCase.test_process_interrupt
TestUnalignedLargeWatchpoint.UnalignedLargeWatchpointTestCase.test_unaligned_large_watchpoint
TestUnwindExpression.UnwindFromExpressionTest.test_unwind_expression_dwarf
TestUnwindExpression.UnwindFromExpressionTest.test_unwind_expression_dwo
Expand Down
2 changes: 1 addition & 1 deletion Support/Testing/Excluded/ds2/linux-aarch64.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ TestHelloWorld.HelloWorldTestCase.test_with_attach_to_process_with_id_api
TestHelloWorld.HelloWorldTestCase.test_with_attach_to_process_with_name_api
TestInferiorCrashing.CrashingInferiorTestCase.test_inferior_crashing_dwarf
TestInferiorCrashing.CrashingInferiorTestCase.test_inferior_crashing_dwo
TestLldbGdbServer.LldbGdbServerTestCase.test_Hc_then_Csignal_signals_correct_thread_launch_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hc_then_Csignal_signals_correct_thread_launch
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_another_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_minus_one_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_zero_pid_llgs
Expand Down
10 changes: 1 addition & 9 deletions Support/Testing/Excluded/ds2/linux-i686.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,14 @@ TestBadAddressBreakpoints.BadAddressBreakpointTestCase.test_bad_address_breakpoi
TestBreakpointSerialization.BreakpointSerialization.test_scripted_extra_args
TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwarf
TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwo
TestCallStopAndContinue.ExprCommandCallStopContinueTestCase.test_dwarf
TestCallStopAndContinue.ExprCommandCallStopContinueTestCase.test_dwo
TestCommandScript.CmdPythonTestCase.test
TestCppGlobalOperators.TestCppGlobalOperators.test_operator_new_dwarf
TestCppGlobalOperators.TestCppGlobalOperators.test_operator_new_dwo
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwarf
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwo
TestDataFormatterGenericMultiSet.GenericMultiSetDataFormatterTestCase.test_with_run_command_libstdcpp_dwo
TestDataFormatterHexCaps.DataFormatterHexCapsTestCase.test_with_run_command_dwo
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwarf
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwo
TestDetachResumes.DetachResumesTestCase.test_detach_resumes
TestDyldExecLinux.TestLinux64ExecViaDynamicLoader.test_with_svr4
TestDyldExecLinux.TestLinux64ExecViaDynamicLoader.test_without_svr4
TestDyldLaunchLinux.TestLinux64LaunchingViaDynamicLoader.test
Expand Down Expand Up @@ -82,8 +79,6 @@ TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_another_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_minus_one_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_zero_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_switches_to_3_threads_launch_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_code_address_as_executable_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_heap_address_as_rw_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_fork_events_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_siginfo_read_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_vfork_events_llgs
Expand All @@ -94,7 +89,6 @@ TestMainThreadExit.ThreadExitTestCase.test
TestMemoryHoles.MemoryHolesTestCase.test_memory_find
TestMemoryRegion.MemoryCommandRegion.test_command
TestMemoryRegion.MemoryCommandRegion.test_no_overlapping_regions
TestNestedAlias.NestedAliasTestCase.test_nested_alias
TestNonStop.LldbGdbServerTestCase.test_exit_llgs
TestNonStop.LldbGdbServerTestCase.test_exit_query_llgs
TestNonStop.LldbGdbServerTestCase.test_leave_nonstop_llgs
Expand Down Expand Up @@ -126,8 +120,6 @@ TestSingleThreadStepTimeout.SingleThreadStepTimeoutTestCase.test_step_over_multi
TestStateAfterExpression.TestStopReasonAfterExpression.test_thread_state_after_expr_dwarf
TestStateAfterExpression.TestStopReasonAfterExpression.test_thread_state_after_expr_dwo
TestSyntheticCapping.SyntheticCappingTestCase.test_with_run_command_dwo
TestThreadBacktraceRepeat.TestThreadBacktracePage.test_thread_backtrace_one_thread
TestThreadBacktraceRepeat.TestThreadBacktracePage.test_thread_backtrace_two_threads
TestThreadJump.ThreadJumpTestCase.test_dwarf
TestThreadJump.ThreadJumpTestCase.test_dwo
TestVectorTypesFormatting.VectorTypesFormattingTestCase.test_with_run_command_dwarf
Expand Down
10 changes: 1 addition & 9 deletions Support/Testing/Excluded/ds2/linux-x86_64.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ TestBreakpointSerialization.BreakpointSerialization.test_scripted_extra_args
TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwarf
TestBreakpointSetRestart.BreakpointSetRestart.test_breakpoint_set_restart_dwo
TestCommandScript.CmdPythonTestCase.test
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwarf
TestDataFormatterCaching.TestDataFormatterCaching.test_with_run_command_dwo
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwarf
TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwo
TestDebuggerAPI.DebuggerAPITestCase.test_CreateTarget_platform
TestDetachResumes.DetachResumesTestCase.test_detach_resumes
TestDyldExecLinux.TestLinux64ExecViaDynamicLoader.test_with_svr4
TestDyldExecLinux.TestLinux64ExecViaDynamicLoader.test_without_svr4
TestDyldLaunchLinux.TestLinux64LaunchingViaDynamicLoader.test
Expand All @@ -22,7 +21,6 @@ TestFrames.FrameAPITestCase.test_get_arg_vals_for_call_stack_dwo
TestGdbRemoteAttachWait.TestGdbRemoteAttachWait.test_attach_with_vAttachWait_llgs
TestGdbRemoteAttachWait.TestGdbRemoteAttachWait.test_launch_after_attach_with_vAttachOrWait_llgs
TestGdbRemoteAttachWait.TestGdbRemoteAttachWait.test_launch_before_attach_with_vAttachOrWait_llgs
TestGdbRemoteExpeditedRegisters.TestGdbRemoteExpeditedRegisters.test_stop_notification_contains_fp_register_llgs
TestGdbRemoteFork.TestGdbRemoteFork.test_T_llgs
TestGdbRemoteFork.TestGdbRemoteFork.test_c_child_llgs
TestGdbRemoteFork.TestGdbRemoteFork.test_c_child_then_parent_llgs
Expand Down Expand Up @@ -81,8 +79,6 @@ TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_another_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_minus_one_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_fails_on_zero_pid_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_Hg_switches_to_3_threads_launch_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_heap_address_as_rw_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qMemoryRegionInfo_reports_stack_address_as_rw_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_fork_events_llgs

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Re-exclude the still-unfixed flaky memory-region test

In the linux-x86_64 matrix in .github/workflows/test-linux.yml, this deletion re-enables test_qMemoryRegionInfo_reports_stack_address_as_rw_llgs, even though repository commit 4e02352 records that it was excluded after being flaky in nightly runs for several weeks, and the subsequent Sources history contains no relevant memory-region fix. Fresh evidence beyond the earlier blanket exclusion comment is that the final tree selectively restores other flakes exposed by the trial run while leaving this specifically documented flake enabled based on a single PASS. When it recurs, run-lldb-tests propagates the failure through pipefail, so retain this exclusion until the flake is fixed or repeated runs establish stability.

Useful? React with 👍 / 👎.

TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_siginfo_read_llgs
TestLldbGdbServer.LldbGdbServerTestCase.test_qSupported_vfork_events_llgs
Expand Down Expand Up @@ -123,9 +119,5 @@ TestSyntheticCapping.SyntheticCappingTestCase.test_with_run_command_dwo
TestTlsGlobals.TlsGlobalTestCase.test_dwarf
TestTlsGlobals.TlsGlobalTestCase.test_dwo
TestUnalignedLargeWatchpoint.UnalignedLargeWatchpointTestCase.test_unaligned_large_watchpoint
TestVectorTypesFormatting.VectorTypesFormattingTestCase.test_with_run_command_dwarf
TestVectorTypesFormatting.VectorTypesFormattingTestCase.test_with_run_command_dwo
lldbsuite.test.lldbtest.TestPrintf.test_dwarf
lldbsuite.test.lldbtest.TestPrintf.test_dwo
lldbsuite.test.lldbtest.TestTypedefArray.test_dwarf
lldbsuite.test.lldbtest.TestTypedefArray.test_dwo
1 change: 1 addition & 0 deletions Support/Testing/Excluded/upstream/android-x86_64.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ TestPythonOSPlugin.PluginPythonOSPlugin.test_python_os_plugin
TestRegisters.RegisterCommandsTestCase.test_fp_register_write
TestRegisters.RegisterCommandsTestCase.test_fs_gs_base
TestReportData.AsanTestReportDataCase.test_dwarf
TestRestartBug.TestRestartBug.test
TestRetryWithStdModule.TestCase.test_dwarf
TestRetryWithStdModule.TestCase.test_dwo
TestScriptedProcess.ScriptedProcesTestCase.test_missing_methods_scripted_register_context
Expand Down
2 changes: 2 additions & 0 deletions Support/Testing/Excluded/upstream/linux-i686.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ TestDynamicValue.DynamicValueTestCase.test_get_dynamic_vals_dwarf
TestDynamicValue.DynamicValueTestCase.test_get_dynamic_vals_dwo
TestFixIts.ExprCommandWithFixits.test_with_dummy_target_dwarf
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_1
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_hiding
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_multi_symbol
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_not_only_first_instruction
TestGDBRemoteClient.TestGDBRemoteClient.test_launch_A
TestGDBRemoteClient.TestGDBRemoteClient.test_launch_A
Expand Down
5 changes: 5 additions & 0 deletions Support/Testing/Excluded/upstream/linux-x86_64.excluded
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ TestDataFormatterPythonSynth.PythonSynthDataFormatterTestCase.test_with_run_comm
TestDataFormatterSynthType.DataFormatterSynthTypeTestCase.test_with_run_command_dwarf
TestDataFormatterSynthType.DataFormatterSynthTypeTestCase.test_with_run_command_dwo
TestFixIts.ExprCommandWithFixits.test_with_dummy_target_dwarf
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_1
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_hiding
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_multi_symbol
TestFrameRecognizer.FrameRecognizerTestCase.test_frame_recognizer_not_only_first_instruction
TestGDBRemoteClient.TestGDBRemoteClient.test_launch_A
TestGDBRemoteClient.TestGDBRemoteClient.test_launch_vRun
TestInferiorChanged.ChangedInferiorTestCase.test_inferior_crashing
Expand All @@ -15,6 +19,7 @@ TestModuleCacheUniversal.ModuleCacheTestcaseUniversal.test
TestOSPluginStepping.TestOSPluginStepping.test_python_os_plugin
TestOSPluginStepping.TestOSPluginStepping.test_python_os_plugin_prune
TestPythonOSPlugin.PluginPythonOSPlugin.test_python_os_plugin
TestRestartBug.TestRestartBug.test
TestScriptedResolver.TestScriptedResolver.test_command_line
TestScriptedResolver.TestScriptedResolver.test_scripted_resolver
TestScriptedResolver.TestScriptedResolver.test_search_depths
Expand Down
Loading