Switch back to online installer for smoke tests #1034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts my previous change in #1032 to disable online installer for smoke tests.
Current explanation is that the test machine is still doing some setup when we start the job. With offline-installer we download the whole thing before starting setup, with online-installer we start setup much sooner; this results in a higher probability of another setup process interfering with the Swift toolchain install.
This PR changes the order of operations so we checkout code before we install the Swift SDK. in my tests this seems to do the trick.
here are a few runs that i kicked off with this change: