Skip to content

Conversation

@speednoisemovement
Copy link
Collaborator

@speednoisemovement speednoisemovement commented Oct 3, 2025

This change uses Azure Trusted Signing to sign all WiX-based outputs if:

  1. inputs.signed is true
  2. The TRUSTED_SIGNING_ACCOUNT secret is set for the repository.

The following secrets are required:

and optionally

  • TRUSTED_SIGNING_TEST_PROFILE, which isn't actively used in the workflow, but is helpful to have in development.

Copy link
Collaborator

@Steelskin Steelskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! So happy to see this finally happening.

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to reduce duplication, one option would be to create the signing metadata once and share that across the jobs in the setup for the signing.

@speednoisemovement
Copy link
Collaborator Author

If you want to reduce duplication, one option would be to create the signing metadata once and share that across the jobs in the setup for the signing.

I don't want to write secrets to disk. I had the template as an env originally, but it broke the env copying code in gha-setup-swift. To be fair, these are not the most secret of secrets, but there's some info disclosure risk so I'm playing it safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants