-
Notifications
You must be signed in to change notification settings - Fork 57
Use Azure Trusted Signing when available #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Azure Trusted Signing when available #1038
Conversation
Steelskin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! So happy to see this finally happening.
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to reduce duplication, one option would be to create the signing metadata once and share that across the jobs in the setup for the signing.
I don't want to write secrets to disk. I had the template as an |
This change uses Azure Trusted Signing to sign all WiX-based outputs if:
inputs.signedis trueTRUSTED_SIGNING_ACCOUNTsecret is set for the repository.The following secrets are required:
AZURE_SP_CREDENTIALS: JSON credentials for an Azure Service Principal with Trusted Signing Certificate Profile Signer roles on the given trusted signing account and certificate profilesTRUSTED_SIGNING_ACCOUNT, an Azure Trusted Signing Account which ownsTRUSTED_SIGNING_PROD_PROFILE(andTRUSTED_SIGNING_TEST_PROFILEwhen used)TRUSTED_SIGNING_PROD_PROFILE, a non-test certificate profileand optionally
TRUSTED_SIGNING_TEST_PROFILE, which isn't actively used in the workflow, but is helpful to have in development.