Skip to content

Use Azure Trusted Signing when available #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
speednoisemovement merged 6 commits into from
Oct 6, 2025
Merged

Use Azure Trusted Signing when available #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7d879f
Trusted signing WIP 2
speednoisemovement Sep 30, 2025
0726cae
Signed = true
speednoisemovement Sep 30, 2025
afa48b7
Inline metadata
speednoisemovement Oct 1, 2025
e468a1c
Use prod profile
speednoisemovement Oct 3, 2025
c65a420
Sep -> Oct
speednoisemovement Oct 6, 2025
a85ab27
Comment fix
speednoisemovement Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/build-toolchain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ on:
required: true
R2_SECRET_ACCESS_KEY:
required: true
AZURE_SP_CREDENTIALS:
required: false
TRUSTED_SIGNING_ACCOUNT:
required: false
TRUSTED_SIGNING_TEST_PROFILE:
required: false
TRUSTED_SIGNING_PROD_PROFILE:
required: false

jobs:
context:
Expand Down Expand Up @@ -309,8 +317,7 @@ jobs:
fi

if [[ "${{ github.event_name }}" == "schedule" || "${{ inputs.signed }}" == "true" ]]; then
# FIXME(compnerd) enable this when requested
echo signed=false >> ${GITHUB_OUTPUT}
echo signed=true >> ${GITHUB_OUTPUT}
else
echo signed=false >> ${GITHUB_OUTPUT}
fi
Expand Down Expand Up @@ -626,6 +633,10 @@ jobs:
R2_ACCOUNT_ID: ${{ secrets.R2_ACCOUNT_ID }}
R2_ACCESS_KEY_ID: ${{ secrets.R2_ACCESS_KEY_ID }}
R2_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
AZURE_SP_CREDENTIALS: ${{ secrets.AZURE_SP_CREDENTIALS }}
TRUSTED_SIGNING_ACCOUNT: ${{ secrets.TRUSTED_SIGNING_ACCOUNT }}
TRUSTED_SIGNING_TEST_PROFILE: ${{ secrets.TRUSTED_SIGNING_TEST_PROFILE }}
TRUSTED_SIGNING_PROD_PROFILE: ${{ secrets.TRUSTED_SIGNING_PROD_PROFILE }}

mac-build:
# TODO: Enable the mac build.
Expand Down
Loading