Fix FormTypeClassValidatorTest on PHPUnit 12.2 (Symfony 8.x CI) - #204
Merged
Conversation
The captureMessages() helper stubbed ConstraintViolationBuilderInterface and configured its setParameter() method. That method returns `static`, which the PHPUnit version simple-phpunit pins on the Symfony 8.x matrix (12.2) cannot configure via createStub() - it throws MethodCannotBeConfiguredException. It passed locally only because we run PHPUnit 12.5. Reuse the file's existing concrete ConstraintViolationBuilderStub (real fluent methods, no mocking) - the same stub the other violation tests in this file already use and which passes CI. Only the builder changes; the context stub, which returns the interface (not static), is unaffected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=========================================
Coverage 27.34% 27.34%
Complexity 2526 2526
=========================================
Files 253 253
Lines 7364 7364
=========================================
Hits 2014 2014
Misses 5350 5350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 PHPUnit errors on the Symfony 8.x / PHP 8.5 CI matrix:
captureMessages()stubbedConstraintViolationBuilderInterfaceand configuredsetParameter(), whose return type isstatic. The PHPUnit versionsymfony/phpunit-bridge'ssimple-phpunitpins on that matrix (12.2) cannot configure astatic-returning method viacreateStub(). It passed locally only because we run 12.5.setParameterwas the only such method configured — the tests that pass CI (incl. others in this same file, andNewEmailAddressValidatorTest) only ever configureatPathor use the concrete stub.Fix: reuse the file's existing concrete
ConstraintViolationBuilderStub(real fluent methods, zero mocking) for the builder — the exact pattern the file's other violation tests already use and which passes CI. The context stub (returns the interface, notstatic) is unchanged.No production changes. Full validator suite green locally.