Added ErrorException handler. #1

xaav · 2011-06-09T14:42:23Z

Changed errors to exceptions, because:

This will probably used in a symfony environment (I'm guessing)
Errors are difficult to handle.

stof · 2011-06-10T09:43:31Z

@xaav As I said in your previous PR, you are only setting an error handler for the testsuite, which is totally useless as this is already done by PHPUnit when you configure it to do it (and it let the user change it through its PHPUnit config). So this change is just useless

Seldaek · 2011-06-10T10:08:59Z

Aye, see https://github.com/composer/composer/blob/master/phpunit.xml.dist#L6

Fixes

Patches

Whitelist dependencies

Fixes

Patches

Whitelist dependencies

The default state for the `TransportException::$response` property is unset and - as testified by the notice in tests -, the `$response` may not be set, resulting in a `null` return value from `TransportException::getResponse()`. Casting to string will preserve the existing behaviour. Fixes: ``` Deprecation triggered by Composer\Test\Util\GitLabTest::testUsernamePasswordFailure: json_decode(): Passing null to parameter composer#1 ($json) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 133) 1 src/Composer/Util/GitLab.php(133): json_decode(NULL, true) 2 tests/Composer/Test/Util/GitLabTest.php(108): Composer\Util\GitLab->authorizeOAuthInteractively('...', '...') ... ```

The default state for the `Perforce::$p4DepotType` property is unset and - as testified by the notice in tests -, the `$p4DepotType` may not be set, resulting in a `null` value being passed to the PHP native `strcmp()` function from within the `p4DepotType::isStream()` method. Casting to string will preserve the existing behaviour. Fixes various notices along the lines of: ``` Deprecation triggered by Composer\Test\Repository\Vcs\PerforceDriverTest::testInitializeCapturesVariablesFromRepoConfig: strcmp(): Passing null to parameter composer#1 ($string1) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 163) 1 src/Composer/Util/Perforce.php(163): strcmp(NULL, '...') 2 src/Composer/Util/Perforce.php(169): Composer\Util\Perforce->isStream() 3 src/Composer/Util/Perforce.php(127): Composer\Util\Perforce->getStream() 4 src/Composer/Util/Perforce.php(191): Composer\Util\Perforce->getClient() 5 src/Composer/Util/Perforce.php(350): Composer\Util\Perforce->getP4ClientSpec() 6 src/Composer/Repository/Vcs/PerforceDriver.php(46): Composer\Util\Perforce->writeP4ClientSpec() 7 tests/Composer/Test/Repository/Vcs/PerforceDriverTest.php(117): Composer\Repository\Vcs\PerforceDriver->initialize() ... ```

The return type of the `Rule::getRequiredPackage()` method effectively was `?string` as, if no matching reason was found, the function wasn't returning anything. In PHP 8.1, this results in 97 notices along the lines of the below from existing tests: ``` Deprecation triggered by Composer\Test\DependencyResolver\SolverTest::testConflictResultEmpty: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 111) 1 src/Composer/DependencyResolver/SolverProblemsException.php(111): strpos(NULL, '...') 2 src/Composer/DependencyResolver/SolverProblemsException.php(44): Composer\DependencyResolver\SolverProblemsException->hasExtensionProblems(Array) 3 tests/Composer/Test/DependencyResolver/SolverTest.php(659): Composer\DependencyResolver\SolverProblemsException->getPrettyString(Object(Composer\Repository\RepositorySet), Object(Composer\DependencyResolver\Request), Object(Composer\DependencyResolver\Pool), false) .... ``` Fixed by returning an empty string if no reason was matched.

…ly fix) Not all tests in the `InstallerTest` class actually create a temporary directory and set the `$this->tempComposerHome` property. Those tests which didn't, throw a notice in PHP 8.1. Fixes 3 notices along the lines of: ``` Deprecation triggered by Composer\Test\InstallerTest::tearDown: is_dir(): Passing null to parameter composer#1 ($filename) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 53) 1 tests/Composer/Test/InstallerTest.php(53): is_dir(NULL) ... ```

The default state for the `ProcessExecutor::$errorOutput` property is "not set" and if there has been no error during the execution of the process, it may well still be, resulting in the return value of `$this->process->getErrorOutput()` being `null`. In that case, we may as well bypass the whole `foreach` as it will never match any of the recognized authentication failure messages. Fixes a total of 5 deprecation notices along the lines of: ``` Deprecation triggered by Composer\Test\Downloader\GitDownloaderTest::testDownloadThrowsRuntimeExceptionIfGitCommandFails: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 340) 1 src/Composer/Util/Git.php(340): strpos(NULL, '...') 2 src/Composer/Util/Git.php(200): Composer\Util\Git->isAuthenticationFailure('...', Array) 3 src/Composer/Downloader/GitDownloader.php(121): Composer\Util\Git->runCommand(Object(Closure), '...', NULL, true) 4 src/Composer/Downloader/VcsDownloader.php(137): Composer\Downloader\GitDownloader->doInstall(Object(Mock_PackageInterface_f8be9ebd), '...', '...') 5 tests/Composer/Test/Downloader/GitDownloaderTest.php(349): Composer\Downloader\VcsDownloader->install(Object(Mock_PackageInterface_f8be9ebd), '...') ... ```

The `LibraryInstallerTest::testUninstall()` method mocks a `Package` object, but did not set an expectation for a call to `getName()`, while that method _is_ called in the `LibraryInstaller::uninstall()` method. Without expectation, the mock returns `null`, which was subsequently being passed on to `strpos()` leading to the below error. Fixes: ``` Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202) 1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...') 2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL) 3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure)) 4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076)) ... ```

The default state for the `ProcessExecutor::$errorOutput` property is "not set" and if there has been no error during the execution of the process, it may well still be, resulting in the return value of `$this->process->getErrorOutput()` being `null`. In that case, we may as well bypass the whole `foreach` as it will never match any of the recognized authentication failure messages. Includes correcting the return type for the `ProcessExecutor::getErrorOutput()` method. There are several alternative solutions possible here: * Set a default value for the `ProcessExecutor::$errorOutput` property of an empty string. * Check within the `ProcessExecutor::getErrorOutput()` method whether the property is set and if not, return an empty string. Not sure what is the best solution, please provide guidance. Fixes a total of 5 deprecation notices along the lines of: ``` Deprecation triggered by Composer\Test\Downloader\GitDownloaderTest::testDownloadThrowsRuntimeExceptionIfGitCommandFails: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 340) 1 src/Composer/Util/Git.php(340): strpos(NULL, '...') 2 src/Composer/Util/Git.php(200): Composer\Util\Git->isAuthenticationFailure('...', Array) 3 src/Composer/Downloader/GitDownloader.php(121): Composer\Util\Git->runCommand(Object(Closure), '...', NULL, true) 4 src/Composer/Downloader/VcsDownloader.php(137): Composer\Downloader\GitDownloader->doInstall(Object(Mock_PackageInterface_f8be9ebd), '...', '...') 5 tests/Composer/Test/Downloader/GitDownloaderTest.php(349): Composer\Downloader\VcsDownloader->install(Object(Mock_PackageInterface_f8be9ebd), '...') ... ```

…of type array, null given

…array, null given (#10529)

…mposer#1 () must be of type string, int given

…ust be of type string, int given (#10897)

Fix string type requirement in case of NULL value: [TypeError] Composer\Command\InitCommand::parseAuthorString(): Argument composer#1 ($author) must be of type string, null given, called in phar:///composer.phar/src/Composer/Command/InitCommand.php on line 345

Fix string type requirement in case of NULL value: [TypeError] Composer\Command\InitCommand::parseAuthorString(): Argument #1 ($author) must be of type string, null given, called in phar:///composer.phar/src/Composer/Command/InitCommand.php on line 345

Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/bin/composer/src/Composer/Util/GitHub.php:103

Added ErrorException handler.

b5bd57a

Seldaek closed this Jun 10, 2011

naderman referenced this issue in naderman/composer Sep 25, 2011

Merge pull request #1 from Seldaek/refactoring

cce4d3a

Fixes

evan108108 mentioned this pull request Nov 2, 2011

Installation exits unexpectedly #85

Closed

naderman added a commit that referenced this issue Apr 29, 2012

Merge pull request #1 from Seldaek/patches

d51ebb9

Patches

davidwindell mentioned this pull request May 17, 2012

Undefined variable: pipes #709

Closed

Seldaek added a commit that referenced this issue May 28, 2012

Merge pull request #1 from naderman/require-update

c8edbca

Whitelist dependencies

ShurikAg mentioned this pull request Jul 5, 2012

Fails to install dependencies randomly. #876

Closed

cevou mentioned this pull request Sep 20, 2012

Wrong command "mode" #1129

Closed

ausprog mentioned this pull request Oct 14, 2012

Cannot Install or Update (First time) - 'mode' not recognised as well as Fatal and Stack trace errors #1208

Closed

p mentioned this pull request Dec 13, 2012

Creating a directory after installation finishes #1417

Closed

KingCrunch mentioned this pull request Dec 20, 2012

ErrorException: proc_open(): fork failed - Cannot allocate memory in phar #945

Closed

kimdcottrell mentioned this pull request Apr 30, 2013

Uncaught exception 'ErrorException' with message 'proc_open(): fork failed - Cannot allocate memory' #1849

Closed

ericbae mentioned this pull request Aug 8, 2013

Composer update gives "cannot allocate memory" error. #2160

Closed

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013

Merge pull request composer#1 from Seldaek/refactoring

9937012

Fixes

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013

Merge pull request composer#1 from Seldaek/patches

496fd0d

Patches

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this issue Nov 22, 2013

Merge pull request composer#1 from naderman/require-update

0ac673a

Whitelist dependencies

mosesontheweb mentioned this pull request Jan 9, 2014

Can't deactivate composer anymore #2570

Closed

sachinjadhav21 mentioned this pull request Mar 17, 2014

Install Fails on Windows with error "not within the allowed path" #2636

Closed

ftdysa mentioned this pull request May 1, 2014

SVNDownloader and --enable-sigchild #2954

Closed

lakshayjain mentioned this pull request Aug 19, 2014

steps for entering the access key & secret key in composer for dynamo db #3220

Closed

ad3n mentioned this pull request Dec 3, 2014

PHP Fatal error: Uncaught exception 'PharException' with message 'internal corruption of phar "/usr/local/bin/composer" (truncated manifest header)' #3495

Closed

ruikc mentioned this pull request Dec 22, 2014

Updating passed 2014-11-05_06-04-18-ffffab3 causes timeout issue with powershell as a post-update-cmd #3573

Closed

ruikc mentioned this pull request Dec 22, 2014

composer update to the version a422d67e2701860a44a4634f62f88b58b8636468 #3586

Closed

anjorinjnr mentioned this pull request Dec 29, 2014

Uncaught exception 'ErrorException' with message 'proc_open(): fork failed - Cannot allocate memory' #3600

Closed

mathewhany mentioned this pull request Apr 30, 2015

Unexpected exit code from Composer (255) #3980

Closed

romeox6x66 mentioned this pull request Jun 7, 2015

ssl #4116

Closed

alexander-schranz mentioned this pull request Sep 2, 2021

Fix GithubDriver nextPage deprecation notice with no link header #10088

Merged

ruudk mentioned this pull request Dec 8, 2021

[2.2.0-RC1] AutoloadGenerator.php crashes when overriding a file using autoload.files + autoload.exclude-from-classmap #10344

Closed

achatpc mentioned this pull request Dec 31, 2021

composer outdated ou composer update Fatal error: Uncaught TypeError #10408

Closed

palmic mentioned this pull request Jan 17, 2022

[PHP 7.1] Composer 2.2.4 fetched from https://getcomposer.org/composer.phar causes "Call to undefined function stream_isatty()" #10464

Closed

glaubinix added a commit to glaubinix/composer that referenced this issue Feb 9, 2022

ComposerRepository: fix array_keys(): Argument composer#1 () must be …

ebfd3a5

…of type array, null given

glaubinix added a commit to glaubinix/composer that referenced this issue Feb 9, 2022

ComposerRepository: fix array_keys(): Argument composer#1 () must be …

9a9c9e5

…of type array, null given

Seldaek pushed a commit that referenced this issue Feb 9, 2022

ComposerRepository: fix array_keys(): Argument #1 () must be of type …

23b0a38

…array, null given (#10529)

Jaimin-Devhero mentioned this pull request Mar 30, 2022

CI CD pipeline error rtrim expects parameter 1 to be string, bool given #10670

Closed

glaubinix added a commit to glaubinix/composer that referenced this issue Jun 24, 2022

Fix: ValidatingArrayLoader fix [TypeError]: strcasecmp(): Argument co…

030ddf7

…mposer#1 () must be of type string, int given

glaubinix added a commit to glaubinix/composer that referenced this issue Jun 24, 2022

Fix: ValidatingArrayLoader fix [TypeError]: strcasecmp(): Argument co…

832695f

…mposer#1 () must be of type string, int given

glaubinix added a commit to glaubinix/composer that referenced this issue Jun 24, 2022

Fix: ValidatingArrayLoader fix [TypeError]: strcasecmp(): Argument co…

fbd3ae2

…mposer#1 () must be of type string, int given

Seldaek pushed a commit that referenced this issue Jun 24, 2022

Fix: ValidatingArrayLoader [TypeError]: strcasecmp(): Argument #1() m…

6776cef

…ust be of type string, int given (#10897)

muazzamazaz mentioned this pull request Jun 28, 2022

Laravel Migrate Issue #10901

Closed

fluffycondor referenced this issue in fluffycondor/composer Jul 4, 2022

Fix deprecation notice

3c3ecc4

Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/bin/composer/src/Composer/Util/GitHub.php:103

fluffycondor referenced this issue in fluffycondor/composer Jul 4, 2022

Fix deprecation notice

6705538

Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/bin/composer/src/Composer/Util/GitHub.php:103

fluffycondor mentioned this pull request Jul 4, 2022

Fix deprecation notice #10921

Merged

Seldaek pushed a commit that referenced this issue Jul 5, 2022

Fix deprecation notice (#10921)

3ebd66b

Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/bin/composer/src/Composer/Util/GitHub.php:103

Added ErrorException handler. #1

Added ErrorException handler. #1

xaav commented Jun 9, 2011

stof commented Jun 10, 2011

Seldaek commented Jun 10, 2011

Added ErrorException handler. #1

Added ErrorException handler. #1

Conversation

xaav commented Jun 9, 2011

stof commented Jun 10, 2011

Seldaek commented Jun 10, 2011