Skip to content

Fix suggest filtering for non-installed packages (#12992) - #13014

Open
ousamabenyounes wants to merge 2 commits into
composer:mainfrom
ousamabenyounes:fix/issue-12992
Open

Fix suggest filtering for non-installed packages (#12992)#13014
ousamabenyounes wants to merge 2 commits into
composer:mainfrom
ousamabenyounes:fix/issue-12992

Conversation

@ousamabenyounes

@ousamabenyounes ousamabenyounes commented Aug 1, 2026

Copy link
Copy Markdown

Fixes #12992.

Summary

  • fail with an InvalidArgumentException when package filters cannot be used
  • preserve input casing in errors while matching installed package names case-insensitively
  • report every missing filter and distinguish locked dev packages excluded by --no-dev

Test verification (RED → GREEN)

Previous PR HEAD with the final regression tests:

FAILURES!
Tests: 37, Assertions: 69, Failures: 5.

Patched result:

OK (37 tests, 74 assertions)
Changed-line coverage: 26/26 = 100%

Full local CI replay is iso-baseline: the same environment-specific 1 error, 5 failures, and 8 skips, with no new failure signature.

Preserve filter casing, report every missing package, and distinguish packages excluded by --no-dev.\n\nRED: 5 focused failures. GREEN: 37 tests, 74 assertions. Diff coverage: 26/26.
@ousamabenyounes

Copy link
Copy Markdown
Author

Addressed the requested filter-validation refinements in 7db53100e: display casing is preserved while matching case-insensitively, all missing filters are reported together, and locked dev packages filtered by --no-dev receive an accurate hint.

Validation: 5 focused cases RED on the previous PR HEAD, then 37 tests / 74 assertions GREEN. run-ci.sh final is iso-baseline, with 26/26 changed executable lines covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Err when providing non-installed package name to suggest

1 participant