Skip to content

Transfer ownership: add missing test #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Transfer ownership: add missing test #1615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 37 additions & 7 deletions tests/Command/TransferOwnershipCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,33 @@ public function testExecuteWithDryRunDoesNothing(): void

$callable = fn (User $user) => $user->getUsernameCanonical();
$this->assertEqualsCanonicalizing(['john', 'alice'], array_map($callable, $package1->getMaintainers()->toArray()));
$this->assertEqualsCanonicalizing(['john', 'bob'], array_map($callable, $package2->getMaintainers()->toArray()));
}

public function testExecuteIgnoresIdenticalMaintainers(): void
{
$this->commandTester->execute([
'vendorOrPackage' => 'vendor1',
'maintainers' => ['alice', 'john'],
]);

$this->commandTester->assertCommandIsSuccessful();

$em = self::getEM();
$em->clear();

$package1 = $em->find(Package::class, $this->package1->getId());
$package2 = $em->find(Package::class, $this->package2->getId());

$this->assertNotNull($package1);
$this->assertNotNull($package2);

$callable = fn (User $user) => $user->getUsernameCanonical();
$this->assertEqualsCanonicalizing(['alice', 'john'], array_map($callable, $package1->getMaintainers()->toArray()));
$this->assertEqualsCanonicalizing(['alice', 'john'], array_map($callable, $package2->getMaintainers()->toArray()));

$record = $this->retrieveAuditRecordForPackage($package1);
$this->assertNull($record, 'No audit log should be created if package maintainers are identical');
$this->assertAuditLogWasCreated($package2, ['john', 'bob'], ['alice', 'john']);
}

public function testExecuteFailsWithUnknownMaintainers(): void
Expand Down Expand Up @@ -159,12 +185,7 @@ public function testExecuteFailsIfNoVendorPackagesFound(): void
*/
private function assertAuditLogWasCreated(Package $package, array $oldMaintainers, array $newMaintainers): void
{
$record = $this->getEM()->getRepository(AuditRecord::class)->findOneBy([
'type' => AuditRecordType::PackageTransferred->value,
'packageId' => $package->getId(),
'actorId' => null,
]);

$record = $this->retrieveAuditRecordForPackage($package);
$this->assertNotNull($record);
$this->assertSame('admin', $record->attributes['actor']);
$this->assertSame($package->getId(), $record->packageId);
Expand All @@ -173,4 +194,13 @@ private function assertAuditLogWasCreated(Package $package, array $oldMaintainer
$this->assertEqualsCanonicalizing($oldMaintainers, array_map($callable, $record->attributes['previous_maintainers']));
$this->assertEqualsCanonicalizing($newMaintainers, array_map($callable, $record->attributes['current_maintainers']));
}

private function retrieveAuditRecordForPackage(Package $package): ?AuditRecord
{
return $this->getEM()->getRepository(AuditRecord::class)->findOneBy([
'type' => AuditRecordType::PackageTransferred->value,
'packageId' => $package->getId(),
'actorId' => null,
]);
}
}