Move array stream parsing funcs to array modules#3025
Merged
harendra-kumar merged 1 commit intomasterfrom May 15, 2025
Merged
Conversation
adithyaov
reviewed
May 14, 2025
| , parseBreakChunksK -- XXX uses Parser, should use parseBreak instead | ||
| , parseBreak | ||
| , parse | ||
| , adapt |
Member
There was a problem hiding this comment.
adapt seems like an incorrect name now that it is in Array module.
adithyaov
reviewed
May 14, 2025
| adaptC :: (Monad m, Unbox a) => Parser a m b -> ParserK (Array a) m b | ||
| adaptC = Array.adapt | ||
|
|
||
| {-# DEPRECATED adaptCG "Use Streamly.Data.Array.Generic.adaptCG" #-} |
Member
There was a problem hiding this comment.
Suggested change
| {-# DEPRECATED adaptCG "Use Streamly.Data.Array.Generic.adaptCG" #-} | |
| {-# DEPRECATED adaptCG "Use Streamly.Data.Array.Generic.adapt" #-} |
harendra-kumar
force-pushed
the
array-parsing
branch
from
4e975dd to
70784a9
Compare
adithyaov
reviewed
May 15, 2025
| , adaptC | ||
| , adapt | ||
| , adaptCG | ||
| , adapt -- XXX rename to parserK, like in Arrays? |
Member
There was a problem hiding this comment.
ParserK.parserK sounds weird. In this case, we can name it to fromParser
harendra-kumar
force-pushed
the
array-parsing
branch
from
70784a9 to
0dd0cd9
Compare
adithyaov
approved these changes
May 15, 2025
harendra-kumar
force-pushed
the
array-parsing
branch
from
0dd0cd9 to
494f848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2663