Move some Unfold and Stream step functions to Producer module#3232
Merged
Conversation
Eta-reducing step functions to arity 1 causes PAP allocations when the stream is composed at runtime (iterated/dynamic pipelines), since the step closure is then called through a dynamic function pointer where GHC cannot inline away the partial applications. Fix by making all arguments explicit on mapM, crossApply, crossApplySnd and crossApplyFst step functions. Document the guideline.
harendra-kumar
force-pushed
the
unfold-producer-move
branch
from
020455d to
d7f6beb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.