Enhance the fold type to capture terminating folds by adithyaov · Pull Request #488 · composewell/streamly

adithyaov · 2020-04-15T06:55:09Z

Closes #455

adithyaov · 2020-04-15T06:56:12Z

I'm yet to fix the folds in the parser modules.

src/Streamly/Internal/Prelude.hs

src/Streamly/Internal/Data/Fold.hs

src/Streamly/Internal/Data/Fold/Types.hs

src/Streamly/Internal/Data/Fold.hs

src/Streamly/Internal/Data/Fold/Types.hs

harendra-kumar · 2020-07-24T08:08:13Z

close and reopen.

harendra-kumar

Do not store the Step constructor in the fold state.
Write the applicative <*> as teeWith function and define the applicative in terms of that. See the parser teeWith functions. Do not store Step in the state.

src/Streamly/Internal/Data/Array.hs

src/Streamly/Internal/Data/Fold/Types.hs

src/Streamly/Internal/Data/Fold.hs

harendra-kumar · 2020-08-21T18:45:46Z

src/Streamly/Internal/Data/Parser/ParserD.hs

@@ -311,21 +319,21 @@ either parser = Parser step initial extract
 take :: Monad m => Int -> Fold m a b -> Parser m a b
 take n (Fold fstep finitial fextract) = Parser step initial extract


This is same as the take in Fold. This is just fromFold (FL.take n fld).

Instead, this can be converted into: take :: Int -> Parser m a b -> Parser m a b.

It will be inconsistent with other takeist combinators.

takeP :: Int -> Parser m a b -> Parser m a b

harendra-kumar · 2020-08-21T18:53:52Z

src/Streamly/Internal/Data/Parser/ParserD.hs

@@ -404,16 +412,16 @@ takeGE cnt (Fold fstep finitial fextract) = Parser step initial extract
 {-# INLINE takeWhile #-}
 takeWhile :: Monad m => (a -> Bool) -> Fold m a b -> Parser m a b
 takeWhile predicate (Fold fstep finitial fextract) =


This is the same as the takeWhile in Folds i.e. fromFold . takeWhile p. This one should now be replaced by the takeWhileP of PR #597 .

src/Streamly/Internal/Data/Parser/ParserD.hs

src/Streamly/Internal/Data/SmallArray.hs

src/Streamly/Internal/Data/Stream/StreamD.hs

harendra-kumar · 2020-08-25T19:04:10Z

Remember to update the changelog for the behavior change of folds.

harendra-kumar

I did not review the split using sequence functions yet. Will review those in the next iteration. Still need to check performance results.

src/Streamly/Internal/Data/Fold.hs

harendra-kumar · 2020-09-14T05:38:22Z

src/Streamly/Internal/Data/Fold.hs

-sum = Fold (\x a -> return $ x + a) (return 0) return
+sum = Fold (\x a -> return $ Partial $ x + a) (return 0) return

+-- XXX Have a terminating condition here if `a == 0`


Remove this comment.

A potential down side is that it cannot be used where only accumulators can be used.

src/Streamly/Internal/Data/Fold.hs

harendra-kumar · 2020-09-14T10:59:00Z

src/Streamly/Internal/Data/Parser/ParserD.hs

+                        return $ Partial n (ManyTillR 0 fs1 l)
+                    FL.Done fb -> return $ Done n fb
+                    -- Keep a count of elements
+                    FL.Done1 _ -> error "Done1 nore supported in manyTill"


Since we are maintaining a count we can return Done cnt fb in this case? Otherwise why are we even maintaining that count, its not being used anywhere.

You can check the previous commit, I initially did that, but for some reason when I looked at it again, I somehow got the idea that it was wrong. Now that I look at it again, it looks fine to me.

src/Streamly/Internal/Data/Parser/ParserD/Types.hs

src/Streamly/Internal/Data/Stream/IsStream.hs

src/Streamly/Internal/Data/Stream/StreamD/Type.hs

* The only difference from the previous implementation is that the `if` statement encompasses `collect` rather then the other way around.

adithyaov · 2020-11-16T18:17:33Z

Look at #770

adithyaov marked this pull request as ready for review April 15, 2020 06:56

adithyaov force-pushed the fold-hf branch 4 times, most recently from 67adb63 to 95ea228 Compare April 15, 2020 13:01

harendra-kumar reviewed Apr 16, 2020

View reviewed changes

adithyaov force-pushed the fold-hf branch 2 times, most recently from 774fedc to 4dbb832 Compare April 24, 2020 11:28

adithyaov force-pushed the fold-hf branch from 810f0b2 to 6e154d7 Compare May 3, 2020 18:14

This was referenced Jun 23, 2020

Add exception handling routines for folds #531

Closed

Naming of parser Step constructors #559

Closed

adithyaov force-pushed the fold-hf branch 2 times, most recently from e8f7efd to c6ec02d Compare July 1, 2020 04:10

adithyaov force-pushed the fold-hf branch 3 times, most recently from f79f964 to 3bdcb85 Compare July 11, 2020 17:10

harendra-kumar reviewed Jul 21, 2020

View reviewed changes

src/Streamly/Internal/Data/Fold/Types.hs Outdated Show resolved Hide resolved

harendra-kumar reviewed Jul 21, 2020

View reviewed changes

src/Streamly/Internal/Data/Fold/Types.hs Outdated Show resolved Hide resolved

adithyaov force-pushed the fold-hf branch 2 times, most recently from 645d96a to 27c7820 Compare July 23, 2020 17:20

harendra-kumar closed this Jul 24, 2020

harendra-kumar reopened this Jul 24, 2020

pranaysashank mentioned this pull request Aug 4, 2020

Applicative instance of Fold and the new Tee type #499

Closed

adithyaov force-pushed the fold-hf branch from 662372d to b6ffcf6 Compare August 6, 2020 03:50

adithyaov force-pushed the fold-hf branch from 92094c5 to d15bce7 Compare August 16, 2020 21:20

harendra-kumar requested changes Aug 21, 2020

View reviewed changes

adithyaov force-pushed the fold-hf branch from e6967ba to 3e497a4 Compare August 26, 2020 22:01

adithyaov added 14 commits September 11, 2020 16:47

fixup! Interim commit

f491349

Expose advance and add moveBy in Ring

7d26e53

fixup! fixup! Interim commit

d4b97db

splitOn Rabin Karp

d787b1b

fixup! splitOn Rabin Karp

05a0172

fixup! fixup! splitOn Rabin Karp

1b0fc46

Fix splitOn

5666f1f

splitSuffixOn

caeb5ae

fixup! splitSuffixOn

67de32b

fixup! fixup! splitSuffixOn

f0c6f8f

fixup! fixup! fixup! splitSuffixOn

ad21107

Indentation

6d0e7bf

Interim review

0d26fd1

Another review commit

86fce93

adithyaov force-pushed the fold-hf branch from 9143717 to 86fce93 Compare September 13, 2020 16:32

adithyaov added 2 commits September 13, 2020 22:25

fixup! Another review commit

84ffab4

Test fix

5340ed2

harendra-kumar requested changes Sep 14, 2020

View reviewed changes

adithyaov added 6 commits September 17, 2020 09:16

Intermediate commit

3f88a4e

Fix bug

95d4c6f

change IsStream groupsBy arg order

83d1e82

Fix build for 822

1c833c1

fixup! Fix build for 822

7bc1e67

Add tests for splitOnSeq and splitOnSuffixSeq

fac225e

harendra-kumar mentioned this pull request Sep 28, 2020

Use -fspec-constr-keen GHC option #703

Open

Update the implementation of lchunksOf

9c8045a

* The only difference from the previous implementation is that the `if` statement encompasses `collect` rather then the other way around.

adithyaov mentioned this pull request Nov 16, 2020

Enhance the fold type to capture terminating folds #770

Closed

adithyaov closed this Nov 16, 2020

adithyaov deleted the fold-hf branch January 11, 2021 22:06

		@@ -311,21 +319,21 @@ either parser = Parser step initial extract
		take :: Monad m => Int -> Fold m a b -> Parser m a b
		take n (Fold fstep finitial fextract) = Parser step initial extract

Conversation

adithyaov commented Apr 15, 2020

Uh oh!

adithyaov commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harendra-kumar commented Jul 24, 2020

Uh oh!

harendra-kumar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harendra-kumar commented Aug 25, 2020

Uh oh!

harendra-kumar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adithyaov commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants