Fix classifySessionsOf#542
Closed
harendra-kumar wants to merge 3 commits intotimesfrom
Closed
Conversation
It was running forever as the timer stream never terminated.
neenaoffline
approved these changes
May 29, 2020
Earlier the sessions that were incomplete and in the hash were dropped when the stream ended.
adithyaov
reviewed
May 29, 2020
| -- , benchIOSink value "toPure" toPure | ||
| -- , benchIOSink value "toPureRev" toPureRev | ||
| ] | ||
| , benchIOSink (value `div` 10) "classifySessionsOf" |
Member
There was a problem hiding this comment.
Change classifySessionsOf to classifySessionsOf/10 maybe to indicate that you're using something other than the default value. It's not a big deal though.
Member
Author
|
This got merged via CLI, but github does not let us change the merge target to master. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.