Skip to content

Replace legacy @myobie/coord references with @myobie/smalltalk #79

Description

@schickling

Summary

Convoy still depends on and imports the pre-rename package @myobie/coord, which has since been renamed to smalltalk (the coord → smalltalk rename upstream). Downstream Nix packaging currently works around this by deleting the bundled @myobie/coord node module and symlinking the smalltalk package in its place — see flakes/external/convoy/flake.nix (installPhase:

rm -rf $out/lib/convoy/node_modules/@myobie/coord
ln -s ${smalltalkPkg}/lib/smalltalk $out/lib/convoy/node_modules/@myobie/coord

That shim works, but it hides the fact that convoy's own source still references the old name.

Where the legacy name lives

  • package.json: "@myobie/coord": "file:../smalltalk" (the dependency itself)
  • src/bus.ts:6: import { createBusReader } from "@myobie/coord";
  • Comment references in src/bus.ts:1 and src/bus.test.ts:7,18

Proposed fix

  1. In package.json, rename the dependency @myobie/coord@myobie/smalltalk (pointing at file:../smalltalk).
  2. Update src/bus.ts:6 (and any other imports) to import from @myobie/smalltalk.
  3. Refresh the inline comments that mention @myobie/coord.

This makes convoy consistent with the renamed package and removes the need for the downstream symlink shim.

Related

Decision 0076 ("retire fleet service cross-machine is coord sync") and the coord → smalltalk rename upstream.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions