eval: cover packaged pty attach stream - #64
Merged
Conversation
agent-session-id: ed878dac-3735-4276-b3e0-ea1b1cd65291 agent-tool: Codex CLI agent-tool-version: 0.145.0 agent-model: unknown agent-runtime-profile: /nix/store/mnx8agbdq3wiyb6vz63lhgscgazkrn98-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/5r69m9k2llmri3na81518zx0a7y0d3cn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@0fb7e03
agent-session-id: ed878dac-3735-4276-b3e0-ea1b1cd65291 agent-tool: Codex CLI agent-tool-version: 0.145.0 agent-model: unknown agent-runtime-profile: /nix/store/mnx8agbdq3wiyb6vz63lhgscgazkrn98-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/5r69m9k2llmri3na81518zx0a7y0d3cn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@0fb7e03
schickling-assistant
force-pushed
the
schickling-assistant/2026-07-31-pty-machine-stream-eval
branch
from
July 31, 2026 12:49
1879000 to
62be35b
Compare
Assert exact initial and reconnect geometry, preserved SGR state, ordered exit, and clean side channels. Add deterministic mutations for each failure boundary. agent-session-id: ed878dac-3735-4276-b3e0-ea1b1cd65291 agent-tool: Codex CLI agent-tool-version: 0.145.0 agent-model: unknown agent-runtime-profile: /nix/store/mnx8agbdq3wiyb6vz63lhgscgazkrn98-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/5r69m9k2llmri3na81518zx0a7y0d3cn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@0fb7e03
Require exactly one deterministic reconnect status and reject unrelated ANSI output through the mutation gate. agent-session-id: ed878dac-3735-4276-b3e0-ea1b1cd65291 agent-tool: Codex CLI agent-tool-version: 0.145.0 agent-model: unknown agent-runtime-profile: /nix/store/mnx8agbdq3wiyb6vz63lhgscgazkrn98-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/5r69m9k2llmri3na81518zx0a7y0d3cn-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@0fb7e03
schickling-assistant
marked this pull request as ready for review
July 31, 2026 13:06
Contributor
Author
|
Thank you, @nathanherald — the ordered packaged attach-stream contract is merged and now has a durable composition eval with exact geometry, color, ordering, and side-channel mutation coverage. Excellent foundation. Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Terminal UIs need the installed PTY command to expose geometry and terminal bytes as one ordered machine stream. Source-level client tests do not prove that the packaged launcher preserves an inherited descriptor, or that reconnect snapshots remain ordered through the complete remote attach composition.
What
Adds a model-free cell that drives the
ptyexecutable onPATHthrough a real target daemon, installedremote-serve, routed attach, controlled transport drop, reconnect, and exit.The held-out checks require:
bin/ptylauncher;GEOMETRY,SCREENframes;GEOMETRY, currentSCREENpair;DATA, and one trailingEXITremain framed;Rationale
The fixture controls only which local route a synthetic
fabric dialreturns and when the first transport connection is dropped. It does not import PTY source modules or invokedist/cli.js. The installed launcher, daemon, remote routing, attach client, snapshot serialization, reconnect loop, and protocol decoder boundary are exercised together.This specifically models the composition a terminal UI such as Fractal consumes, without mechanically copying the upstream unit suite.
Dependencies and proof
Depends on merged PTY main containing compoundingtech/pty#140 and compoundingtech/pty#141 at
d5fabc3917407aeb937a012bd97679c303e18033.Focused proof against the package built from exact merged PTY commit
d5fabc3917407aeb937a012bd97679c303e18033:d5fabc3:SCORE: 7 PASS / 0 FAIL / 7 gating judgespty 0.12.0: expected red; the launcher rejects the fd option and emits no machine frames24x80to13x47min-wins geometry, red SGR preservation, current reconnect state, final DATA/EXIT, and clean side channels: passThe composed cell, VRS check, catalog generation, and complete model-free corpus preflight are green against the merged package and the corpus-pinned st2
0fed14brelease. The published st2 archive and extracted binary matched their documented SHA256 identities; no gate was weakened or skipped.Posted on behalf of @schickling
agent_nameagent_session_idagent_toolagent_tool_versionagent_runtimeagent_modelruntime_profileskills_manifestworktreemachinetooling_profile