Remove Resource _tag and derive profiles from URI schemes - #262
Merged
Conversation
schickling
marked this pull request as ready for review
August 17, 2026 14:23
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resource identity already lives in
uri, but Agent Specs also carried_tag. The two discriminators could disagree and required special legacy handling.Goal
Make the URI scheme the sole Resource-profile discriminator and reject
_taglike any unsupported Resource attribute.Decisions
_tagdiagnostic.resource "work" uri="worktree://dev3/srv/project" relation="used" reason="Current checkout."resource "work" _tag="worktree" ....Verification
1be318b5d884778bac4dabba97e45558edc4931cnix develop -c cargo check --workspacenix develop -c cargo test --workspace --no-rungit diff --checkComplexity
Reduces complexity by removing a field and its compatibility paths; no new abstraction or dependency.
Concerns
Breaking syntax change. Consumers must migrate before adopting this st2 revision.
Friction & bottlenecks
No persistent tooling friction or measured bottleneck found in this repository.
Follow-ups
Coordinated consumers are covered by compoundingtech/evals#77 and schickling/dotfiles#1705.
References
Closes #256.