fix(vista): bound artifact versions to safe integers - #426
Merged
schickling-assistant merged 1 commit intoSep 3, 2026
Merged
Conversation
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
schickling-assistant
marked this pull request as ready for review
September 3, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Vista provider admitted positive 19-digit artifact versions, but the packaged Vista CLI rejects values above JavaScript's maximum safe integer. Such a URI passed Resource admission and then could not be fetched by the backend.
Goal
Keep provider admission aligned with the backend by accepting versions through
9007199254740991and rejecting larger decimal versions.Decisions
Use the backend's exact safe-integer ceiling in the provider parser rather than adding coercion or a runtime fallback. The boundary test covers the maximum, the first rejected value, and the former 19-digit upper edge.
Verification
nix develop -c cargo test -p st2-vista-component— 8 tests passed, including the safe-integer boundary test.Complexity
No new complexity; one existing bound is narrowed.
Concerns
None.
Friction & bottlenecks
No persistent friction or measurable bottleneck encountered.
Follow-ups
The consuming dotfiles stack updates its Vista resolver to enforce the same limit.
References
Companion to the WASIp2 provider cutover in dotfiles.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile