fix: lint errors

[pedronauck]

Summary by CodeRabbit

• Refactor

  • Consolidated many string keys and standardized internal handling across providers, CLI, daemon, and APIs for greater consistency.
  • Replaced several reverse-loop implementations with clearer iteration utilities.
  • Unified error/type extraction patterns for more consistent internal error handling.

• Chores

  • Broad code cleanup, tests updated/added, and internal reorganizations with no user-facing behavior changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agh-site	Ready	Preview, Comment	May 19, 2026 2:34pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8d47bb75-466d-48b9-88e6-7e41a2eb0cb5

📥 Commits

Reviewing files that changed from the base of the PR and between a61707e and b91ecce.

📒 Files selected for processing (3)

• internal/daemon/native_tools.go
• internal/daemon/native_tools_test.go
• internal/network/delivery.go

🚧 Files skipped from review as they are similar to previous changes (2)

• internal/network/delivery.go
• internal/daemon/native_tools.go

---

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

[coderabbitai]

Actionable comments posted: 6

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

internal/extension/host_api.go (1)

2607-2612: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use errors.As per coding guidelines for error type extraction.

The coding guidelines specify using errors.Is() and errors.As() for error checking. Line 2607 uses the generic form errors.AsType; switch to the standard errors.As approach:

Suggested fix

-	if rpcErr, ok := errors.AsType[*subprocess.RPCError](err); ok {
+	var rpcErr *subprocess.RPCError
+	if errors.As(err, &rpcErr) {
 		if rpcErr.Code == HostAPIRateLimitedCode {
 			return hostAPIStatusRPCError(429, "Rate limited", rpcErr.Data)
 		}
 		return err
 	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/extension/host_api.go` around lines 2607 - 2612, The code currently
uses errors.AsType to extract a *subprocess.RPCError; replace that with the
standard errors.As pattern: declare a variable var rpcErr *subprocess.RPCError
and call if errors.As(err, &rpcErr) { ... } so you still check rpcErr.Code ==
HostAPIRateLimitedCode and return hostAPIStatusRPCError(429, "Rate limited",
rpcErr.Data) (or return err otherwise); update the branch that references
subprocess.RPCError, HostAPIRateLimitedCode, and hostAPIStatusRPCError
accordingly.

🧹 Nitpick comments (2)

internal/network/delivery.go (1)

47-47: 💤 Low value

Consider more readable backtick representation.

The \x60 hex escape sequence for backticks reduces readability. While technically correct, Go string literals can contain literal backticks directly:

protocolGuidanceDirectRoomText = "Direct-room chat uses `--kind say --surface direct`."

This is clearer than hex escapes and maintains the same functionality.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/network/delivery.go` at line 47, The string constant
protocolGuidanceDirectRoomText currently uses the hex escape \x60 for backticks
which hurts readability; replace the escaped backticks with literal backtick
characters so the value reads: Direct-room chat uses `--kind say --surface
direct`. Update the declaration of protocolGuidanceDirectRoomText to use the
clearer literal backticks while preserving the exact text and punctuation.

internal/daemon/native_tools.go (1)

1058-1060: ⚡ Quick win

Keep native tool JSON keys owned by native_tools.go.

HarnessPromptSectionSkills and TurnOriginNetwork belong to other contracts. Reusing them here means a rename in prompt rendering or turn metadata can silently change native tool payloads. Please keep these response keys local to this package.

♻️ Proposed change

 const (
+	nativeToolsNetworkKey   = "network"
+	nativeToolsSkillsKey    = "skills"
 	nativeToolsAgentRootKey     = "agent_root"
 	nativeToolsAgentSubagentKey = "agent_subagent"
 	...
 )

-	map[string]any{string(HarnessPromptSectionSkills): payload},
+	map[string]any{nativeToolsSkillsKey: payload},

-	return structuredNetworkResult(map[string]any{string(TurnOriginNetwork): payload}, payload.Status)
+	return structuredNetworkResult(map[string]any{nativeToolsNetworkKey: payload}, payload.Status)

-	string(HarnessPromptSectionSkills): core.WorkspaceSkillPayloads(resolved.Skills),
+	nativeToolsSkillsKey: core.WorkspaceSkillPayloads(resolved.Skills),

Also applies to: 1079-1081, 1160-1160, 2010-2014

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/daemon/native_tools.go` around lines 1058 - 1060, The code is using
external constants HarnessPromptSectionSkills and TurnOriginNetwork as JSON keys
inside native_tools.go which risks accidental renames; define package-local key
constants (e.g., nativeToolsSkillsKey and nativeToolsTurnOriginKey) in
native_tools.go and replace uses of string(HarnessPromptSectionSkills) and
string(TurnOriginNetwork) in the structuredResult/map constructions (the
occurrences that produce the native tool payloads) to use these new local
constants so native tool JSON keys remain owned by this package.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/acp/handlers.go`:
- Around line 558-560: Replace the non-standard errors.AsType usage with the
project-standard errors.As pattern: declare a variable of type
*acpsdk.RequestError (e.g., requestErr) and call errors.As(err, &requestErr); if
that returns true, return requestErr. Update the check around the existing err,
replacing the errors.AsType[*acpsdk.RequestError](err) expression with the
errors.As(err, &requestErr) form and return the captured requestErr.

In `@internal/api/core/agent_channels.go`:
- Around line 157-161: The SendRequest constructions use
new(network.SurfaceThread) / new(network.SurfaceDirect) which create pointers to
empty string zero-values, causing normalizeOptionalSurface to turn them into nil
and trigger "surface is required" in Send(); fix by creating actual pointers to
the desired constant string values (e.g., assign the constant surface value to a
local variable and take its address, or use an immediately-evaluated
variable/closure to return a *network.Surface with the constant) when populating
SendRequest.Surface in the SendRequest creation sites (refer to SendRequest,
network.SurfaceThread, network.SurfaceDirect, normalizeOptionalSurface and
Send()) so the pointer points to "thread" or "direct" rather than to "".

In `@internal/api/core/network_test.go`:
- Around line 341-342: The test is using new(network.SurfaceDirect) and
new("...") which are invalid; instead create addressable variables and take
their pointers: declare a local variable holding the constant value (e.g., sd :=
network.SurfaceDirect) and set Surface to &sd, and likewise declare d :=
"direct_0123456789abcdef0123456789abcdef" and set DirectID to &d; update the
other occurrences (e.g., the instances around lines 1018-1019) the same way so
pointers to values are used rather than calling new on constants.

In `@internal/api/udsapi/agent_channels_test.go`:
- Line 360: The test wrongly uses new(network.SurfaceDirect) even though
network.SurfaceDirect is a constant value of type Surface and source.Surface
expects a *Surface; fix by creating a local variable of type network.Surface
(e.g., assign network.SurfaceDirect to a local variable) and assign its address
to source.Surface (so replace the new(...) expression with taking the address of
a local variable holding network.SurfaceDirect).

In `@internal/cli/provider.go`:
- Around line 462-463: Replace the non‑idiomatic errors.AsType usage with
errors.As: declare a variable var exitErr *exec.ExitError before the error
checks, then change the checks that currently use
errors.AsType[*exec.ExitError](err) to use errors.As(err, &exitErr) (apply the
same change for both occurrences around the existing return/result logic), so
the code tests the error type using the repository standard errors.As and the
exitErr variable.

In `@internal/daemon/native_tools.go`:
- Around line 39-40: The actor-kind comparisons in denySubagentMemoryWrite and
recordMemoryToolWrite rely on exact strings but memoryCallerActorKind() only
trims spaces; call ActorKind.Normalize() on the value returned by
memoryCallerActorKind() (or otherwise normalize before comparing) so comparisons
against nativeToolsAgentRootKey and nativeToolsAgentSubagentKey work regardless
of case; also replace the file-local string literals with properly typed
ActorKind constants (e.g., const AgentRoot ActorKind = "agent_root",
AgentSubagent ActorKind = "agent_subagent") and use those constants in the
comparisons.

---

Outside diff comments:
In `@internal/extension/host_api.go`:
- Around line 2607-2612: The code currently uses errors.AsType to extract a
*subprocess.RPCError; replace that with the standard errors.As pattern: declare
a variable var rpcErr *subprocess.RPCError and call if errors.As(err, &rpcErr) {
... } so you still check rpcErr.Code == HostAPIRateLimitedCode and return
hostAPIStatusRPCError(429, "Rate limited", rpcErr.Data) (or return err
otherwise); update the branch that references subprocess.RPCError,
HostAPIRateLimitedCode, and hostAPIStatusRPCError accordingly.

---

Nitpick comments:
In `@internal/daemon/native_tools.go`:
- Around line 1058-1060: The code is using external constants
HarnessPromptSectionSkills and TurnOriginNetwork as JSON keys inside
native_tools.go which risks accidental renames; define package-local key
constants (e.g., nativeToolsSkillsKey and nativeToolsTurnOriginKey) in
native_tools.go and replace uses of string(HarnessPromptSectionSkills) and
string(TurnOriginNetwork) in the structuredResult/map constructions (the
occurrences that produce the native tool payloads) to use these new local
constants so native tool JSON keys remain owned by this package.

In `@internal/network/delivery.go`:
- Line 47: The string constant protocolGuidanceDirectRoomText currently uses the
hex escape \x60 for backticks which hurts readability; replace the escaped
backticks with literal backtick characters so the value reads: Direct-room chat
uses `--kind say --surface direct`. Update the declaration of
protocolGuidanceDirectRoomText to use the clearer literal backticks while
preserving the exact text and punctuation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ddbaefe4-7268-4139-96d7-8808ce7c4af5

📥 Commits

Reviewing files that changed from the base of the PR and between 2fd680b and a61707e.

⛔ Files ignored due to path filters (2)

• internal/sandbox/daytona/sidecar_assets/agh-daytona-sidecar-linux-amd64.gz is excluded by !**/*.gz
• internal/sandbox/daytona/sidecar_assets/agh-daytona-sidecar-linux-arm64.gz is excluded by !**/*.gz

📒 Files selected for processing (256)

• cmd/agh-codegen/main.go
• extensions/bridges/discord/provider.go
• extensions/bridges/gchat/provider.go
• extensions/bridges/github/api.go
• extensions/bridges/github/provider.go
• extensions/bridges/linear/api.go
• extensions/bridges/linear/provider.go
• extensions/bridges/slack/provider.go
• extensions/bridges/teams/provider.go
• extensions/bridges/telegram/provider.go
• extensions/bridges/whatsapp/provider.go
• internal/acp/client.go
• internal/acp/config_options.go
• internal/acp/failure.go
• internal/acp/handlers.go
• internal/acp/permission.go
• internal/acp/terminal.go
• internal/agentidentity/errors.go
• internal/api/contract/contract.go
• internal/api/core/agent_channels.go
• internal/api/core/automation.go
• internal/api/core/bridges.go
• internal/api/core/errors.go
• internal/api/core/handlers.go
• internal/api/core/model_catalog_conversions.go
• internal/api/core/network_test.go
• internal/api/core/payload_helpers_test.go
• internal/api/core/prompt_stream.go
• internal/api/core/resources.go
• internal/api/core/session_stream.go
• internal/api/core/settings.go
• internal/api/core/tasks.go
• internal/api/httpapi/handlers.go
• internal/api/httpapi/middleware.go
• internal/api/httpapi/prompt.go
• internal/api/httpapi/server.go
• internal/api/spec/authored_context.go
• internal/api/spec/model_catalog.go
• internal/api/spec/spec.go
• internal/api/testutil/resource_stub.go
• internal/api/udsapi/agent_channels_test.go
• internal/automation/model/validate.go
• internal/automation/schedule.go
• internal/automation/trigger.go
• internal/automation/trigger_filter.go
• internal/bridges/delivery_broker.go
• internal/bridgesdk/errors.go
• internal/bridgesdk/peer.go
• internal/bridgesdk/runtime.go
• internal/bundles/resource_projection.go
• internal/bundles/resource_store.go
• internal/bundles/service.go
• internal/cli/agent.go
• internal/cli/agent_kernel.go
• internal/cli/authored_context.go
• internal/cli/automation.go
• internal/cli/bridge.go
• internal/cli/bundle.go
• internal/cli/client.go
• internal/cli/client_tools.go
• internal/cli/config.go
• internal/cli/daemon.go
• internal/cli/doc.go
• internal/cli/docpost/docpost.go
• internal/cli/extension.go
• internal/cli/extension_marketplace.go
• internal/cli/hooks.go
• internal/cli/install.go
• internal/cli/lifecycle.go
• internal/cli/mcp_auth.go
• internal/cli/memory.go
• internal/cli/network.go
• internal/cli/observe.go
• internal/cli/provider.go
• internal/cli/provider_models.go
• internal/cli/resource.go
• internal/cli/root.go
• internal/cli/session.go
• internal/cli/skill_commands.go
• internal/cli/skill_output.go
• internal/cli/skill_workspace.go
• internal/cli/spawn.go
• internal/cli/task.go
• internal/cli/tool.go
• internal/cli/tool_operator.go
• internal/cli/update.go
• internal/cli/vault.go
• internal/cli/whoami.go
• internal/cli/workspace.go
• internal/codegen/sdkts/generate.go
• internal/config/bootstrap.go
• internal/config/config.go
• internal/config/dotenv.go
• internal/config/merge.go
• internal/config/persistence.go
• internal/config/provider.go
• internal/config/tool_surface.go
• internal/daemon/authored_context_runtime.go
• internal/daemon/boot.go
• internal/daemon/boundary.go
• internal/daemon/bridges.go
• internal/daemon/coordinator_runtime.go
• internal/daemon/daemon.go
• internal/daemon/daemon_test.go
• internal/daemon/harness_context.go
• internal/daemon/harness_reentry_bridge.go
• internal/daemon/hook_agent_events.go
• internal/daemon/hooks_bridge.go
• internal/daemon/memory_runtime.go
• internal/daemon/native_automation_tools.go
• internal/daemon/native_config_hook_tools.go
• internal/daemon/native_extension_tools.go
• internal/daemon/native_mcp_auth_tools.go
• internal/daemon/native_memory_admin_tools.go
• internal/daemon/native_profile_tools.go
• internal/daemon/native_review_tools.go
• internal/daemon/native_task_notification_tools.go
• internal/daemon/native_tools.go
• internal/daemon/prompt_sections.go
• internal/daemon/restart.go
• internal/daemon/sandbox_reconcile.go
• internal/daemon/scheduler_runtime.go
• internal/daemon/spawn_reaper.go
• internal/daemon/task_event_bridge_notifier.go
• internal/daemon/task_role_runtime.go
• internal/daemon/task_runtime.go
• internal/e2elane/lanes.go
• internal/extension/capability.go
• internal/extension/contract/host_api.go
• internal/extension/contract/sdk.go
• internal/extension/describe.go
• internal/extension/host_api.go
• internal/extension/host_api_authored_context.go
• internal/extension/host_api_bridges.go
• internal/extension/host_api_network.go
• internal/extension/manager.go
• internal/extension/manifest.go
• internal/extension/memory_provider_registry.go
• internal/extension/model_source_test.go
• internal/extensiontest/bridge_adapter_harness.go
• internal/heartbeat/authoring.go
• internal/heartbeat/heartbeat.go
• internal/hooks/dispatch_events.go
• internal/hooks/executor_subprocess.go
• internal/hooks/hooks.go
• internal/hooks/introspection.go
• internal/hooks/matcher.go
• internal/hooks/permission.go
• internal/hooks/types.go
• internal/logger/logger.go
• internal/mcp/auth/metadata.go
• internal/mcp/auth/pkce.go
• internal/mcp/auth/service.go
• internal/mcp/executor.go
• internal/mcp/hosted.go
• internal/mcp/hosted_proxy.go
• internal/memory/catalog.go
• internal/memory/dream_v2.go
• internal/memory/lock.go
• internal/memory/lock_test.go
• internal/memory/observability.go
• internal/memory/recall_source.go
• internal/modelcatalog/live_sources.go
• internal/modelcatalog/modelsdev.go
• internal/modelcatalog/modelsdev_test.go
• internal/network/delivery.go
• internal/network/manager.go
• internal/network/stats.go
• internal/network/tasks.go
• internal/network/validate.go
• internal/observe/health.go
• internal/observe/retention.go
• internal/observe/tasks.go
• internal/procutil/detached.go
• internal/registry/github/client.go
• internal/registry/installer.go
• internal/registry/multi.go
• internal/sandbox/daytona/cmd/agh-daytona-sidecar/main.go
• internal/sandbox/daytona/env.go
• internal/sandbox/daytona/provider.go
• internal/sandbox/daytona/sdk.go
• internal/sandbox/daytona/ssh.go
• internal/scheduler/scheduler.go
• internal/session/manager_clear.go
• internal/session/provider_runtime.go
• internal/session/repair.go
• internal/session/resume_repair.go
• internal/session/runtime_overrides.go
• internal/session/sandbox.go
• internal/settings/classify.go
• internal/settings/collections.go
• internal/settings/sections.go
• internal/skills/loader.go
• internal/skills/marketplace/service.go
• internal/skills/observe_events.go
• internal/skills/provenance.go
• internal/skills/registry.go
• internal/skills/registry_workspace_cache.go
• internal/skills/watcher.go
• internal/soul/authoring.go
• internal/soul/soul.go
• internal/store/globaldb/global_db.go
• internal/store/globaldb/global_db_mcp_auth.go
• internal/store/globaldb/global_db_network_conversations.go
• internal/store/globaldb/global_db_session.go
• internal/store/globaldb/global_db_task_claim.go
• internal/store/globaldb/global_db_task_review.go
• internal/store/globaldb/migrate_soul.go
• internal/store/globaldb/migrate_task_orchestration_profile.go
• internal/store/globaldb/migrate_task_review_gate.go
• internal/store/globaldb/migrate_workspace.go
• internal/store/sql_helpers.go
• internal/store/sqlite.go
• internal/store/types.go
• internal/subprocess/transport.go
• internal/task/lease.go
• internal/task/manager.go
• internal/testutil/acpmock/fixture.go
• internal/testutil/e2e/artifacts.go
• internal/testutil/e2e/mock_agents.go
• internal/testutil/e2e/runtime_harness.go
• internal/testutil/e2e/transport_parity.go
• internal/tools/builtin/authored_context.go
• internal/tools/builtin/automation.go
• internal/tools/builtin/autonomy.go
• internal/tools/builtin/bridges.go
• internal/tools/builtin/catalog.go
• internal/tools/builtin/config.go
• internal/tools/builtin/extensions.go
• internal/tools/builtin/hooks.go
• internal/tools/builtin/mcp_auth.go
• internal/tools/builtin/memory.go
• internal/tools/builtin/memory_admin.go
• internal/tools/builtin/network.go
• internal/tools/builtin/observe.go
• internal/tools/builtin/provider_models.go
• internal/tools/builtin/sessions.go
• internal/tools/builtin/skills.go
• internal/tools/builtin/tasks.go
• internal/tools/builtin/workspace.go
• internal/tools/builtin_ids.go
• internal/tools/dispatch.go
• internal/tools/errors.go
• internal/tools/result.go
• internal/tools/result_limit.go
• internal/update/github.go
• internal/vault/types.go
• packages/site/lib/__tests__/landing-truth.test.tsx
• sdk/examples/secret-guard/main.go
• sdk/examples/telegram-reference/main.go
• sdk/go/digest.go
• sdk/go/errors.go
• sdk/go/extension.go
• sdk/go/result.go
• sdk/go/transport.go
• sdk/go/types.go

💤 Files with no reviewable changes (3)

• internal/daemon/spawn_reaper.go
• internal/api/core/tasks.go
• internal/daemon/task_runtime.go