refactor: enable AGH network by default for new installs

[pedronauck]

Why

Network is AGH's main differentiator, so new installs should expose it immediately instead of requiring manual opt-in.

What changed

• flipped the built-in network.enabled default to true
• kept explicit user opt-out working for existing and manually disabled configs
• added Go regression coverage for default, override, first-run, upgrade-style, and integration/runtime paths
• updated the runtime configuration docs to reflect the new default
• stabilized the web Vitest timeout budget so make verify remains reliable under full-suite load

Files changed

• internal/config/config.go
• internal/config/config_test.go
• internal/config/bootstrap_test.go
• internal/testutil/e2e/runtime_harness_test.go
• internal/daemon/daemon_test.go
• internal/api/core/test_helpers_test.go
• internal/api/httpapi/helpers_test.go
• internal/api/httpapi/server_test.go
• internal/api/udsapi/helpers_test.go
• internal/api/udsapi/server_test.go
• packages/site/content/runtime/core/configuration/config-toml.mdx
• web/vitest.config.ts
• web/src/storybook/web-storybook-stories-and-fixtures.test.tsx

Tests and coverage

• verified the default config path now enables network when no explicit value is provided
• verified explicit network.enabled = false still wins for manual config and bootstrap/upgrade-style persisted configs
• verified first-run/bootstrap and e2e runtime harness flows keep network enabled by default
• verified enabled-network daemon boot still late-binds session callbacks and rejects non-bindable session managers
• ran focused Go package tests for the touched runtime and API packages
• ran cd web && bun run test:raw
• ran make verify

Analysis

Local pre-change analysis reference: /tmp/agh-network-analysis.md

Summary by CodeRabbit

• Configuration Changes

  • Network is enabled by default; explicit disables are preserved when provided.

• Tests

  • Test infrastructure updated for consistent network handling and to allow explicit test-time network disabling.
  • Strengthened bootstrap tests around network persistence.
  • Improved test timeouts and reliability for frontend tests.

[coderabbitai]

Walkthrough

Default network config changed: Network.Enabled now defaults to true. Tests and test utilities were updated to explicitly disable networking when required; new test coverage verifies default, explicit disable, and persistence behavior.

Changes

Cohort / File(s)	Summary
Test Helpers — API handler tests internal/api/core/test_helpers_test.go, internal/api/httpapi/helpers_test.go, internal/api/udsapi/helpers_test.go	Added local testConfigWithDisabledNetwork(homePaths) helpers (delegating to testutil.ConfigWithDisabledNetwork) and updated handler test fixtures to use them instead of aghconfig.DefaultWithHome(...).
API test utilities internal/api/testutil/apitest.go	Added exported ConfigWithDisabledNetwork(homePaths aghconfig.HomePaths) aghconfig.Config to produce a default config with Network.Enabled set to false for tests.
Server Tests — HTTP & UDS internal/api/httpapi/server_test.go, internal/api/udsapi/server_test.go	Replaced uses of aghconfig.DefaultWithHome(...) with testConfigWithDisabledNetwork(...) in server tests; per-test overrides for host/port/socket remain unchanged.
Config core defaults internal/config/config.go	Changed built-in default: Config.Network.Enabled in DefaultWithHome now defaults to true (was false).
Config tests & bootstrap persistence internal/config/config_test.go, internal/config/bootstrap_test.go	Updated tests to expect Network.Enabled == true by default; added tests ensuring explicit [network] enabled = false is respected and persisted across Save/Load cycles.
Daemon tests & session harness changes internal/daemon/daemon_test.go	Updated tests to assume network enabled by default; extended test fakes (fakeSessionManager) with no-op lifecycle/network prompt methods and added wrapper types (syntheticPrompter, nonBindableHarnessSessionManager) to support synthetic prompting in tests.
Runtime harness e2e tests internal/testutil/e2e/runtime_harness_test.go	Refactored runtime harness test to table-driven subtests verifying default-enabled behavior, explicit disable, and precedence when seed options request enabling while a mutation disables it.
Web test timeouts web/vitest.config.ts, web/src/storybook/web-storybook-stories-and-fixtures.test.tsx	Added global Vitest testTimeout: 10_000 and an explicit timeout: 20_000 for a specific storybook test.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• refactor: project structure #7: Earlier test helper refactor leveraged by this PR.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.88% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: enabling the AGH network by default for new installations, which is the core objective of this PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

internal/api/httpapi/helpers_test.go (1)

421-425: Centralize testConfigWithDisabledNetwork.

This helper is now duplicated in internal/api/httpapi/helpers_test.go, internal/api/udsapi/helpers_test.go, and internal/api/core/test_helpers_test.go. Moving it into shared testutil would reduce drift the next time config defaults change.

As per coding guidelines, **/*_test.go: "Check for shared test utilities usage to avoid duplication".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/api/httpapi/helpers_test.go` around lines 421 - 425, Centralize the
duplicated helper by creating a single exported function
TestConfigWithDisabledNetwork in a shared testutil package that returns an
aghconfig.Config with Network.Enabled = false (replicating the body of
testConfigWithDisabledNetwork), then update callers in tests to import the
shared testutil and call testutil.TestConfigWithDisabledNetwork(...) and remove
the duplicate local testConfigWithDisabledNetwork implementations; ensure the
signature and return type match usages (uses aghconfig.HomePaths ->
aghconfig.Config) so no call-sites need further changes.

internal/testutil/e2e/runtime_harness_test.go (1)

35-65: Split the three network scenarios into subtests.

This packs three distinct behaviors into one test body, so the first failure hides the rest and the cases cannot be parallelized independently. A small table with t.Run("Should ...") would fit the suite better.

As per coding guidelines, **/*_test.go: "Use table-driven tests with subtests (t.Run) as default pattern for Go tests" and "Add t.Parallel() to independent subtests in Go tests".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/testutil/e2e/runtime_harness_test.go` around lines 35 - 65, Split
TestPrepareRuntimeLayoutUsesEnabledNetworkByDefaultAndAllowsExplicitDisable into
three subtests using t.Run so each scenario runs independently and can call
t.Parallel(): one subtest for default behavior (call prepareRuntimeLayout(t,
RuntimeHarnessOptions{}) and assert defaulted.Config.Network.Enabled), one for
explicit disable (use RuntimeHarnessOptions with ConfigSeed:
ConfigSeedOptions{Mutate: func(cfg *aghconfig.Config){cfg.Network.Enabled =
false}} and assert disabled.Config.Network.Enabled is false), and one for
explicit enable overriding a seeded false (set EnableNetwork: true with the same
ConfigSeed mutate and assert enabled.Config.Network.Enabled is true); keep
assertions the same but place t.Parallel() inside each subtest to allow parallel
execution.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@internal/config/bootstrap_test.go`:
- Around line 110-192: The two standalone tests
(TestSaveBootstrapConfigFirstRunKeepsNetworkEnabledByDefault and
TestSaveBootstrapConfigPreservesExplicitNetworkDisable) violate the project
guideline requiring table-driven subtests; refactor them into a single
table-driven test that iterates over cases and calls t.Run("Should ...", func(t
*testing.T){ ... }) for each scenario, referencing the same helpers
(ResolveHomePathsFrom, SaveBootstrapConfig, LoadGlobalConfig, writeFile) inside
each subtest; ensure each subtest calls t.Parallel() as appropriate, uses
descriptive "Should..." names, and asserts the same expectations currently in
the two functions (first-run default network enabled and preserving explicit
network disabled + default_channel) so behavior and file contents checks remain
unchanged.

In `@internal/daemon/daemon_test.go`:
- Around line 4333-4350: Add compile-time interface assertions for the test
double type to prevent future drift: add lines like `var _ session.Manager =
(*fakeSessionManager)(nil)` (or the concrete session interface type used in
production) next to the fakeSessionManager definition to assert it implements
SetNetworkPeerLifecycle, SetTurnEndNotifier, PromptNetwork, and IsPrompting;
also add the same form of assertion for any other newly added test doubles
mentioned (e.g., the types around lines 4476-4491) so the compiler verifies the
interface contract.

---

Nitpick comments:
In `@internal/api/httpapi/helpers_test.go`:
- Around line 421-425: Centralize the duplicated helper by creating a single
exported function TestConfigWithDisabledNetwork in a shared testutil package
that returns an aghconfig.Config with Network.Enabled = false (replicating the
body of testConfigWithDisabledNetwork), then update callers in tests to import
the shared testutil and call testutil.TestConfigWithDisabledNetwork(...) and
remove the duplicate local testConfigWithDisabledNetwork implementations; ensure
the signature and return type match usages (uses aghconfig.HomePaths ->
aghconfig.Config) so no call-sites need further changes.

In `@internal/testutil/e2e/runtime_harness_test.go`:
- Around line 35-65: Split
TestPrepareRuntimeLayoutUsesEnabledNetworkByDefaultAndAllowsExplicitDisable into
three subtests using t.Run so each scenario runs independently and can call
t.Parallel(): one subtest for default behavior (call prepareRuntimeLayout(t,
RuntimeHarnessOptions{}) and assert defaulted.Config.Network.Enabled), one for
explicit disable (use RuntimeHarnessOptions with ConfigSeed:
ConfigSeedOptions{Mutate: func(cfg *aghconfig.Config){cfg.Network.Enabled =
false}} and assert disabled.Config.Network.Enabled is false), and one for
explicit enable overriding a seeded false (set EnableNetwork: true with the same
ConfigSeed mutate and assert enabled.Config.Network.Enabled is true); keep
assertions the same but place t.Parallel() inside each subtest to allow parallel
execution.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4831e02c-a0f9-408c-8946-fec5d7a69b9e

📥 Commits

Reviewing files that changed from the base of the PR and between 33f4ee4 and 8877ca6.

⛔ Files ignored due to path filters (1)

• packages/site/content/runtime/core/configuration/config-toml.mdx is excluded by !**/*.mdx

📒 Files selected for processing (12)

• internal/api/core/test_helpers_test.go
• internal/api/httpapi/helpers_test.go
• internal/api/httpapi/server_test.go
• internal/api/udsapi/helpers_test.go
• internal/api/udsapi/server_test.go
• internal/config/bootstrap_test.go
• internal/config/config.go
• internal/config/config_test.go
• internal/daemon/daemon_test.go
• internal/testutil/e2e/runtime_harness_test.go
• web/src/storybook/web-storybook-stories-and-fixtures.test.tsx
• web/vitest.config.ts

[coderabbitai]

🧹 Nitpick comments (1)

internal/api/testutil/apitest.go (1)

38-43: Consider completing helper adoption to avoid mixed test defaults.

There are still direct aghconfig.DefaultWithHome(homePaths) call sites in API tests (e.g., internal/api/httpapi/httpapi_integration_test.go around Line 1022 and internal/api/udsapi/udsapi_integration_test.go around Line 802). Migrating those to this helper will keep network behavior consistent across test suites.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/api/testutil/apitest.go` around lines 38 - 43, Some API tests still
call aghconfig.DefaultWithHome(homePaths) directly, causing mixed network
defaults; update those tests to call the new helper
ConfigWithDisabledNetwork(homePaths) instead so cfg.Network.Enabled is
consistently false across suites, and adjust any assertions that assumed
networking was enabled to reflect the disabled-network behavior; search for
usages of DefaultWithHome(...) in API tests and replace them with
ConfigWithDisabledNetwork(...).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@internal/api/testutil/apitest.go`:
- Around line 38-43: Some API tests still call
aghconfig.DefaultWithHome(homePaths) directly, causing mixed network defaults;
update those tests to call the new helper ConfigWithDisabledNetwork(homePaths)
instead so cfg.Network.Enabled is consistently false across suites, and adjust
any assertions that assumed networking was enabled to reflect the
disabled-network behavior; search for usages of DefaultWithHome(...) in API
tests and replace them with ConfigWithDisabledNetwork(...).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 034fe128-a38e-447a-b43e-3f88b2dae664

📥 Commits

Reviewing files that changed from the base of the PR and between 8877ca6 and 24c99e7.

⛔ Files ignored due to path filters (5)

• .compozy/tasks/network-default/reviews-001/_meta.md is excluded by !**/*.md
• .compozy/tasks/network-default/reviews-001/issue_001.md is excluded by !**/*.md
• .compozy/tasks/network-default/reviews-001/issue_002.md is excluded by !**/*.md
• .compozy/tasks/network-default/reviews-001/issue_003.md is excluded by !**/*.md
• .compozy/tasks/network-default/reviews-001/issue_004.md is excluded by !**/*.md

📒 Files selected for processing (7)

• internal/api/core/test_helpers_test.go
• internal/api/httpapi/helpers_test.go
• internal/api/testutil/apitest.go
• internal/api/udsapi/helpers_test.go
• internal/config/bootstrap_test.go
• internal/daemon/daemon_test.go
• internal/testutil/e2e/runtime_harness_test.go

🚧 Files skipped from review as they are similar to previous changes (2)

• internal/testutil/e2e/runtime_harness_test.go
• internal/api/core/test_helpers_test.go