feat: Allow YouTube urls in media section of models - #884
Merged
Conversation
reject non-YouTube codebase video URLs
test degenerate urls as well
Rename the unshipped codebase media field from youtube_url to video_source_url, keeping YouTube-specific validation while leaving room for future video providers. Update the release editor media form and gallery to use the generic video source naming, persist sparse video updates via PATCH, and preserve tags on partial serializer updates. Fix video gallery sizing so embedded video previews keep a 16:9 aspect ratio instead of stretching in the fixed-height image frame. Add targeted backend and frontend tests for video source validation, partial update persistence, and the minimal media payload. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separating from #874
Also adds emitted events to the
BootstrapModalclass to make it simpler to pause the video when the media modal is closed.