docs(mix): repair broken and stale links - #1012
Merged
Merged
Conversation
Audited every external URL in the repository and fixed the ones that were broken or resolving through redirect chains. Broken (404): - mix_lint README pointed Mix at github.com/virtuallyio/mix, a dead org. - A test doc comment and a changelog entry referenced issue URLs under repo names that no longer resolve for issue paths. Stale: - The logo images and license badges in four READMEs were served from a personal fork (raw.githubusercontent.com/leoafarias/mix) rather than the project repository, so the pub.dev listings depended on that fork existing. - fluttermix.com/docs/* links took three redirects to reach their target. They now point directly at www.fluttermix.com/documentation/mix/*. - opensource.org and conventionalcommits.org links followed their upstream canonical moves. Also fixes the exports generator. Running `melos run exports` on main added an export for the @internal FocusHighlightModeProvider, which fails analysis with invalid_export_of_internal_element; the path heuristic only skips src/internal/. Adding it to excludedPaths makes regeneration idempotent and analysis-clean. Parity fixtures pinning cdn.tailwindcss.com and the verbatim OFL font license are intentionally untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
None.
Description
I audited every external URL in the repository (95 unique links, excluding lockfiles and templates) by actually requesting each one, and fixed the results that were broken or resolving through redirect chains.
Broken links (404)
packages/mix_lint/README.mdgithub.com/virtuallyio/mixgithub.com/btwld/mixpackages/mix/test/src/core/nested_style_variant_test.dartgithub.com/btwld/remix/issues/59github.com/conceptadev/remix/issues/59packages/mix/CHANGELOG.mdgithub.com/leoafarias/mix/issues/59github.com/conceptadev/mix/issues/59The
mix_lintone is user-facing on pub.dev. GitHub does not redirect issue paths for moved repositories, so those two had to use the canonicalconceptadevnames — see the open question below.Stale links
README.md,packages/mix/README.md,packages/mix_annotations/README.md, andpackages/mix_generator/README.mdwere served fromraw.githubusercontent.com/leoafarias/mix— a personal fork. The pub.dev listings for three published packages rendered their logo and licence badge from it. Nowbtwld/mix. (assets/dark.svgandassets/light.svgalready exist in this repo.)fluttermix.com/docs/*took three redirects (/docs/*→/documentation/*→/documentation/mix/*, plus apex → www). All now point directly athttps://www.fluttermix.com/documentation/mix/*, which resolves in zero hops. This includes the ecosystem link, which now targets the renamedmix-windspage.opensource.org/licenses/mit-license.php→opensource.org/license/mitandconventionalcommits.org→www.conventionalcommits.org, following their upstream canonical moves.Exports generator fix
Regenerating with
melos run exportsonmainaddsexport 'src/core/providers/focus_highlight_mode_provider.dart';, which fails analysis:FocusHighlightModeProvideris@internal, but it lives insrc/core/providers/and the generator's heuristic only skipssrc/internal/. It was added in #1006 and the barrel was never regenerated, so the drift was latent. Adding it toexcludedPaths— alongside the existing documented exclusions — makesmelos run exportsidempotent and analysis-clean.Deliberately untouched
cdn.tailwindcss.cominexample/real_tailwind/*.html— unpinned on purpose; pinning it would move the parity baselines.example/assets/fonts/roboto/OFL.txt— a verbatim upstream licence document.github.com/leoafariasin the plugin manifests — a personal profile link, correctly personal.github.com/orgs/btwld/projects/6inadd_to_ai_initiatives_board.yml— returns 404 anonymously, but org projects are private by default and my token lacksread:project, so I could not confirm either way. Left alone.Open question (not addressed here)
Every
github.com/btwld/*link in this repo resolves through one permanent redirect togithub.com/conceptadev/*— the repositories are canonically underconceptadev, whilebtwld/mix-docsis canonicallybtwld. The same pattern holds acrossremix,ack,naked_ui, androcketsin the docs repo. That is ~19 links here and ~80 in mix-docs, and which direction is correct is a branding decision, so I left them asbtwldand only usedconceptadevwherebtwldgenuinely 404s. Happy to normalize either way.Validation
melos run exports— regenerates with no drift.fvm dart analyzeinpackages/mix— no issues (was 1 warning after regeneration).melos run analyze:dart— all packages clean.melos run ci— passed.dart format --set-exit-if-changedon all changed Dart files — 0 changed.