Skip to content

feat: Support header on scaffold - #554

Merged
leoafarias merged 8 commits into
mainfrom
faet/support-header-on-scaffold
Feb 7, 2025
Merged

feat: Support header on scaffold#554
leoafarias merged 8 commits into
mainfrom
faet/support-header-on-scaffold

Conversation

@tilucasoli

Copy link
Copy Markdown
Collaborator

Description

As most part of application needs a app bar or a header, and both material and cupertino contain a app bar in their range of components we decided to create one.

Changes

  • Refactor the way Scaffold was rendering its children
  • Create the an AppBar component

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel

vercel Bot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 2:40pm

@github-actions github-actions Bot added the remix label Feb 6, 2025
@tilucasoli tilucasoli changed the title Feat: Support header on scaffold feat: Support header on scaffold Feb 6, 2025

@leoafarias leoafarias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias
leoafarias merged commit 4ed6405 into main Feb 7, 2025
@leoafarias
leoafarias deleted the faet/support-header-on-scaffold branch February 7, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants