fix: harden auth recovery and request context - #36
Draft
leoafarias wants to merge 4 commits into
Draft
Conversation
This was referenced Aug 8, 2026
leoafarias
force-pushed
the
agent/rockets-auth-hardening
branch
from
August 8, 2026 23:53
a089fdb to
a080064
Compare
leoafarias
force-pushed
the
agent/rockets-auth-hardening
branch
from
August 8, 2026 23:56
a080064 to
f2f18fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden authentication recovery and make request context explicit across every local auth CQRS and repository hop. This removes security-sensitive logging and sequencing gaps while tightening the supported controller surface.
Stacked on #34; review this PR against
agent/rockets-server-composition.Changes
RecoveryServicetoken.POST /recovery/passcode, and remove secrets and stacks from logs.falsepassword-history result before credential writes; finish reset and OTP clearing transactionally before best-effort notification.AppContextHostcontext through auth commands, queries, ports, guards, invitations, listeners, and repository access.Type of Change
Verification
corepack yarn build)yarn lint)Checklist
Compatibility
POST /recovery/passcodewith{ passcode }; the former GET route is removed.