test(page-chain): P7 final connected-mode verification pass - #290
Merged
Conversation
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #286 -> #284 -> #275 -> #268; retarget as bases merge.
Closes #271.
Pure verification additions — no feature work. Every hole found was filed as its own ticket, not patched here: #287 (CLI surface bypasses the decide() gate), #288 (tanstack verb group lacks bootConnect parity coverage), #289 (non-builtin registry page tools fall back to the generic card).
What this adds
packages/embed/test/page-dispatch-parity.it.test.tspackages/core/test/chat/page-gate-surfaces.it.test.tspackages/ui-kit-chat-tools/test/registry-card-declarations.browser.test.tsxreachableflips with page connection; page.effect describes the real host-effect driver (post-#227) with its UNKNOWN_EFFECT declaration in the signature; every declaring tool's errors survive intocatalog.getpackages/extensions/page/test/catalog-honesty.test.tspackages/core/test/page-chain-grep-zero.test.tsPlus
packages/core/test/helpers/fake-widget.ts: the fake widget page-bus peer the three core page ITs previously each hand-rolled (fallow flagged the third copy as introduced duplication; the two existing files now share it too).Grep-zero evidence
All ten retired identifiers scan to zero over
packages/**/srcandapps/conciv/src(now enforced by the test on every run):DOM_HANDLERS,PAGE_QUERY_KINDS,PageVerbMap,page.run,dispatchExtVerb,scopedPageCaller,BUILTIN_PAGE_TOOLS,callPageVerb,MUTATING_KINDS,MIRROR_KINDS. Grounding: plantingexport const DOM_HANDLERS = {}inpackages/core/src/page-bus.tsfails the test naming that file.Parity evidence (local run)
page-dispatch-parity.it.test.ts: 10/10 — the identical five-assertion battery passes under bootNormal (widget embed) and bootConnect (connect handle + connectGate preflight). tanstack group: bootNormal covered by the existing tanstack suite (router-adapter.it.test.ts); bootConnect gap filed as #288.Gates (local, all exit 0)
pnpm turbo run typecheck build --filter='!@conciv/extension-whiteboard'— 107/107VITEST_MAX_FORKS=1 pnpm turbo run test --concurrency=1 --filter='!@conciv/extension-whiteboard'— 102/102pnpm lint— 96/96;pnpm format:check— cleanpnpm exec fallow audit --changed-since origin/effect-verb-227 --format json— verdict pass, zero INTRODUCEDCI
GitHub Actions is currently degraded; the full-suite-green criterion (incl. whiteboard suite and e2e consumer apps, which never run locally) lands when CI recovers — do not merge on local evidence alone.
🤖 Generated with Claude Code