Fix getting ref for lightweight tags - #477
Merged
Merged
Conversation
There was an issue in our jq query where the `ref` would be empty for repos that used lightweight tags. I incorrectly thought the `//` worked on empty strings, but it actually only works on values null and false. Adding `map(select(. != ""))` turns the empty string into a null value, making our `//` in the next part of the query work as desired. I only noticed this issue with lightweight tags, so added lightweight tags to the existing tests. Also added checks to ensure `ref` is never empty when emitting versions. Signed-off-by: Taylor Silva <dev@taydev.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue in our jq query where the
refwould be empty for repos that used lightweight tags. Example of what this looked like in ci:I incorrectly thought the
//worked on empty strings, but it actually only works on values null and false. Addingmap(select(. != ""))turns the empty string into a null value, making our//in the next part of the query work as desired.I only noticed this issue with lightweight tags, so added lightweight tags to the existing tests. Also added checks to ensure
refis never empty when emitting versions.