linux-{aarch64,ppc64le}: reenable optimizations#739
linux-{aarch64,ppc64le}: reenable optimizations#739conda-forge-admin merged 10 commits intoconda-forge:mainfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
68d2fc0 to
7c96871
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin restart ci |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.05.14.14.53
|
This is ready for review. |
|
@conda-forge-admin please rerender |
| # Get an updated config.sub and config.guess | ||
| cp $BUILD_PREFIX/share/libtool/build-aux/config.* . | ||
|
|
||
| if [[ ! -d ${BUILD_PREFIX}/python-bin ]]; then |
There was a problem hiding this comment.
Why are you removing this? This actually adds some reproducibility to the build as otherwise it will depend on a Python "from the outside".
There was a problem hiding this comment.
This particular code started to fail recently:
CondaEnvException: The specified prefix '/home/conda/feedstock_root/build_artifacts/python-split_1730476599894/_build_env/python-bin' appears to be a top level directory within an existing conda environment (i.e., {history_file} exists). Creating an environment in this location has the potential to irreversibly corrupt your conda installation and/or other conda environments, please choose a different location for your new conda environment. Aborting.
I didn't know it was related to reproducibility, the comment only mentioned that it is related to an update of the Python version.
Does it not use the Python installed by miniforge when this code is removed?
I guess we could create another subdir within python-bin to install the new python env, if you prefer.
…nda-forge-pinning 2024.11.22.06.04.18
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12186964946. Examine the logs at this URL for more detail. |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12177119293. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)