Skip to content

linux-{aarch64,ppc64le}: reenable optimizations#739

Merged
conda-forge-admin merged 10 commits intoconda-forge:mainfrom
matthiasdiener:opt-ppc_arm
Dec 5, 2024
Merged

linux-{aarch64,ppc64le}: reenable optimizations#739
conda-forge-admin merged 10 commits intoconda-forge:mainfrom
matthiasdiener:opt-ppc_arm

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented Nov 1, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Recipe maintainer "chrisburr" does not exist
  • Recipe maintainer "isuruf" does not exist
  • Recipe maintainer "jakirkham" does not exist
  • Recipe maintainer "mbargull" does not exist
  • Recipe maintainer "msarahan" does not exist
  • Recipe maintainer "pelson" does not exist
  • Recipe maintainer "ocefpaf" does not exist
  • Recipe maintainer "scopatz" does not exist
  • Recipe maintainer "katietz" does not exist
  • Recipe maintainer "xhochy" does not exist

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin restart ci

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

This is ready for review.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Nov 22, 2024

@conda-forge-admin please rerender

Comment thread recipe/build_base.sh Outdated
# Get an updated config.sub and config.guess
cp $BUILD_PREFIX/share/libtool/build-aux/config.* .

if [[ ! -d ${BUILD_PREFIX}/python-bin ]]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this? This actually adds some reproducibility to the build as otherwise it will depend on a Python "from the outside".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular code started to fail recently:

CondaEnvException: The specified prefix '/home/conda/feedstock_root/build_artifacts/python-split_1730476599894/_build_env/python-bin' appears to be a top level directory within an existing conda environment (i.e., {history_file} exists). Creating an environment in this location has the potential to irreversibly corrupt your conda installation and/or other conda environments, please choose a different location for your new conda environment. Aborting.

See e.g. https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1069578&view=logs&jobId=990aae91-fe23-5de4-c4f0-736a9beaff76&j=990aae91-fe23-5de4-c4f0-736a9beaff76&t=1d9a1434-ca3f-5eff-8f1a-395ed215aa80

I didn't know it was related to reproducibility, the comment only mentioned that it is related to an update of the Python version.

Does it not use the Python installed by miniforge when this code is removed?

I guess we could create another subdir within python-bin to install the new python env, if you prefer.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Nov 22, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12186964946. Examine the logs at this URL for more detail.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Dec 5, 2024

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12177119293. Examine the logs at this URL for more detail.

@xhochy xhochy added the automerge Merge the PR when CI passes label Dec 5, 2024
@conda-forge-admin conda-forge-admin merged commit cf4d8d6 into conda-forge:main Dec 5, 2024
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@matthiasdiener matthiasdiener deleted the opt-ppc_arm branch December 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants