Add action for preparing authors - #470
Merged
Merged
Conversation
conda-bot
added
the
cla-signed
danyeaw
force-pushed
the
add-prepare-authors
branch
from
June 24, 2026 21:24
6d75aab to
04d25b3
Compare
jaimergp
reviewed
Jul 12, 2026
danyeaw
added a commit
to conda-sandbox/example
that referenced
this pull request
Aug 11, 2026
Seed an incomplete .authors.yml and a dispatch workflow pinned to the PR head so we can validate prepare/check modes with org SYNC_TOKEN.
run() used str.strip(), which removed the leading space from git status lines such as " M .authors.yml" and truncated the path to authors.yml, failing ensure_allowed_paths in prepare mode.
Keep the elevated token input for checkout/push/PR only, and resolve commit authors with the job GITHUB_TOKEN so prepare no longer drops github keys when a write PAT is supplied.
for more information, see https://pre-commit.ci
Stop reporting authors metadata as complete when missing github keys cannot be filled; check mode still warns without failing.
for more information, see https://pre-commit.ci
jezdez
requested changes
Aug 12, 2026
jezdez
left a comment
jezdez
left a comment
Member
There was a problem hiding this comment.
Thanks for putting this together, Dan. The overall shape looks good, especially keeping read lookups on the job token and writes on the supplied token. I found a few correctness cases that can make check or prepare report success with incomplete data, so I think they need another pass before merge. I kept the comments focused on the smallest fixes.
# Conflicts: # pyproject.toml
Member
Author
|
Hi @jezdez, thanks for the great review comments. I updated the PR to fix all those items with tests for them. I also reran tests on https://github.com/conda-sandbox/example to check the functionality. It all appears good. |
jezdez
approved these changes
Aug 24, 2026
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR goes along with #459 to prepare the
.authors.ymlfile prior to a release. It is based on the initial script developed by @dholth at regro/rever#276 to check and update the file prior to running rever.I tested this in a sandbox with conda-sandbox/example#7 and conda-sandbox/example#8.