night-shift: knowledge writegate stderr (#161) - #169
Merged
Conversation
![lexi-chief-of-staff[bot]](https://avatars.githubusercontent.com/in/3490641?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ship it.
- Hash-duplicate now exits SUCCESS (was FAILURE); matches night-shift unattended worker goal.
- Category validation softened to warning + null; test updated accordingly.
- New --quiet flag routes validation/write-gate messages to stderr only when not set.
- RememberTool duplicate response simplified; schema change removes enum on category.
- One new test for --skip-enhance; no behavior change on enhancement path.
No blocking issues. Minor: raw fwrite on stderr could use Command output helpers for consistency.
Custom {--quiet} collided with Symfony's built-in and blew up every
KnowledgeAddCommand test. Use output->isQuiet() instead, dual-write
errors to Prompts + STDERR, keep hard category/hash failure paths, and
restore QdrantService in handleDuplicate.
There was a problem hiding this comment.
Blocking issues: duplicate STDERR writes in emitError/emitWarning, missing enum justification in RememberTool schema change, and absent tests for quiet-mode output.
- emit* helpers duplicate every message to STDERR on top of error()/warning() calls.
- Category schema lost its enum without comment or migration note.
- Test only covers skip-enhance; no coverage of the new quiet behavior introduced for unattended runs.
Non-blocking but worth addressing before the next unattended worker lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unattended local-worker ship for
knowledge-161-writegate-stderr(modelqwen-coder-32k:latest).Jordan vote 2026-09-06: local unattended typing must open a shit-agents PR or fail.
Files (3):
app/Commands/KnowledgeAddCommand.phpapp/Mcp/Tools/RememberTool.phptests/Feature/Commands/KnowledgeAddCommandTest.phpCloses #161