Add "connect delete <name>" CLI command#13
Merged
Conversation
Joshua Buss (chicagobuss)
approved these changes
May 14, 2018
Brian Strauch (brianstrauch)
pushed a commit
that referenced
this pull request
May 31, 2023
* feat: add gateway api minispec submodule * feat: add a way to generate sdk from gateway minispec branch * feat: show how to use and make import available
airlock-confluentinc Bot
pushed a commit
that referenced
this pull request
May 29, 2026
…nterval, add Delay Addresses Channing review #11/#13/#14 on PR #197 (companion generator PR) by tightening the wait API and the Flink statement reference adoption. * pkg/wait: rename Options.Tick / PhaseOptions.Tick to PollInterval to match terraform-provider-confluent's StateChangeConf vocabulary. Add Delay (initial sleep before the first Fetch) mirroring StateChangeConf.Delay — gives the API a moment to materialize the resource after a POST, reducing eventually-consistent 404s on the first poll. New tests TestPoll_DelayPostponesFirstFetch and TestPoll_DelayRespectsCtxCancellation cover the contract. * Flink statement create (cloud + on-prem): drop the clierrors alias on pkg/errors and use direct == compare against wait.ErrFailed / wait.ErrTimeout. The wait sentinels are package-level vars returned directly from Poll (never wrapped), so == is correct and avoids importing stdlib errors alongside the CLI errors package — which matches the rest of the codebase's import convention. * Timeout error now includes the latest observed phase: "wait timed out: statement \"x\" is still in phase \"PENDING\"" rather than the bare "wait timed out". Updated create-wait-timeout.golden accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@confluentinc/caas