Add Stream Sharing commands for provider shares list, describe and delete by stkr89 · Pull Request #1367 · confluentinc/cli

Sumit Tokkar (stkr89) · 2022-07-19T18:49:33Z

Checklist

[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
- yes: ok
- no: DO NOT MERGE until the required functionalities are live in prod

What

Adding Stream Sharing commands for provider shares list, describe and delete

References

CLI commands for Stream Sharing

Test & Review

Added integration tests

go.mod

internal/cmd/command.go

internal/cmd/command_test.go

internal/cmd/stream-share/command.go

internal/cmd/stream-share/command_provider_share_delete.go

test/fixtures/output/stream-share/describe-provider-share.golden

test/test-server/streamsharing_handler.go

…r-consumer-shared-resources # Conflicts: # go.sum

Sumit Tokkar (stkr89) · 2022-07-20T16:49:14Z

Brian Strauch (@brianstrauch) How can I put the stream-share command behind a feature flag?

internal/cmd/stream-share/command_provider_share_list.go

internal/pkg/ccloudv2/stream-share.go

test/test-server/streamsharing_handler.go

internal/cmd/stream-share/command_provider_share.go

Brian Strauch (brianstrauch) · 2022-07-20T17:51:04Z

Brian Strauch (@brianstrauch) How can I put the stream-share command behind a feature flag?

Take a look at #1303 for an example!

…r-consumer-shared-resources

internal/cmd/stream-share/command_provider_share.go

internal/cmd/stream-share/command_provider_share_delete.go

internal/pkg/ccloudv2/stream-share.go

internal/pkg/ccloudv2/utils.go

test/test-server/streamsharing_handler.go

internal/cmd/command.go

internal/cmd/stream-share/command_provider_share.go

internal/cmd/stream-share/command_provider_share_delete.go

internal/cmd/stream-share/command_provider_share_list.go

internal/pkg/errors/strings.go

test/test-server/streamsharing_handler.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…-for-provider-consumer-shared-resources' into stokkar/CDX-386-add-cli-commands-for-provider-consumer-shared-resources

…r-consumer-shared-resources # Conflicts: # internal/pkg/ccloudv2/client.go # test/test-server/ccloudv2_router.go

internal/cmd/stream-share/command.go

internal/pkg/ccloudv2/client.go

internal/pkg/ccloudv2/stream-share.go

internal/pkg/errors/strings.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…r-consumer-shared-resources # Conflicts: # internal/cmd/command.go # test/test-server/ccloudv2_router.go

go.mod

internal/cmd/stream-share/command_provider_share.go

internal/cmd/stream-share/command_provider.go

internal/cmd/stream-share/command_provider_share.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

internal/cmd/stream-share/command_provider.go

internal/cmd/stream-share/command_provider_share_describe.go

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

…shared-resources' of github.com:confluentinc/cli into stokkar/CDX-386-add-cli-commands-for-provider-consumer-shared-resources

Sumit Tokkar (stkr89) added 4 commits July 19, 2022 09:59

Add Stream Sharing command to list provider shares

89c81a3

updated test cases

7084acb

added command to describe provider share

1aa7e9b

added command to delete provider share

34d3dca

Sumit Tokkar (stkr89) requested review from Alex Cheng (atxalex8) and Brian Strauch (brianstrauch) July 19, 2022 18:49

Sumit Tokkar (stkr89) requested a review from a team as a code owner July 19, 2022 18:49

Brian Strauch (brianstrauch) reviewed Jul 19, 2022

View reviewed changes

Sumit Tokkar (stkr89) added 4 commits July 20, 2022 11:07

updates as per PR comments

a0a9006

fixed lint errors

bee897e

Merge branch 'main' into stokkar/CDX-386-add-cli-commands-for-provide…

0bc4941

…r-consumer-shared-resources # Conflicts: # go.sum

fixed module errors

09205fb

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) July 20, 2022 16:49

Brian Strauch (brianstrauch) reviewed Jul 20, 2022

View reviewed changes

Sumit Tokkar (stkr89) added 5 commits July 20, 2022 13:48

sorted imports and updated import alias

1c32e60

refactored pagination logic

01beed9

updated test fixtures

2047129

Merge branch 'main' into stokkar/CDX-386-add-cli-commands-for-provide…

7d51f9e

…r-consumer-shared-resources

move stream-share command behind LD feature flag

af4ae92

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) July 25, 2022 18:52

Brian Strauch (brianstrauch) reviewed Jul 25, 2022

View reviewed changes

updates as per PR comments

e99a1d8

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) July 26, 2022 19:14

Brian Strauch (brianstrauch) reviewed Jul 26, 2022

View reviewed changes

Sumit Tokkar (stkr89) and others added 4 commits July 26, 2022 16:22

Update internal/cmd/stream-share/command_provider_share_delete.go

781fd6a

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update test/test-server/streamsharing_handler.go

b099c55

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/pkg/errors/strings.go

b6c122a

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_share_list.go

7f4839f

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Sumit Tokkar (stkr89) added 2 commits July 28, 2022 15:04

mark stream-share command as hidden

39e08c3

Merge remote-tracking branch 'origin/stokkar/CDX-386-add-cli-commands…

ccad946

…-for-provider-consumer-shared-resources' into stokkar/CDX-386-add-cli-commands-for-provider-consumer-shared-resources

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) July 28, 2022 20:05

Sumit Tokkar (stkr89) added 2 commits July 28, 2022 17:07

use updated method names

c2e68e8

Merge branch 'main' into stokkar/CDX-386-add-cli-commands-for-provide…

ba0d370

…r-consumer-shared-resources # Conflicts: # internal/pkg/ccloudv2/client.go # test/test-server/ccloudv2_router.go

Brian Strauch (brianstrauch) reviewed Jul 29, 2022

View reviewed changes

internal/cmd/stream-share/command.go Show resolved Hide resolved

internal/pkg/ccloudv2/client.go Outdated Show resolved Hide resolved

internal/pkg/ccloudv2/stream-share.go Outdated Show resolved Hide resolved

internal/pkg/errors/strings.go Outdated Show resolved Hide resolved

Brian Strauch (brianstrauch) mentioned this pull request Jul 29, 2022

Remove server configuration description #1379

Merged

Sumit Tokkar (stkr89) and others added 5 commits August 1, 2022 09:44

Update internal/pkg/ccloudv2/client.go

c009c6a

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/pkg/ccloudv2/stream-share.go

df11e99

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/pkg/errors/strings.go

a042508

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

code refactor

85394f9

Merge branch 'main' into stokkar/CDX-386-add-cli-commands-for-provide…

8c1abdf

…r-consumer-shared-resources # Conflicts: # internal/cmd/command.go # test/test-server/ccloudv2_router.go

Sumit Tokkar (stkr89) requested review from a team and Brian Strauch (brianstrauch) August 1, 2022 18:24

Brian Strauch (brianstrauch) reviewed Aug 4, 2022

View reviewed changes

Sumit Tokkar (stkr89) and others added 4 commits August 4, 2022 14:04

Update internal/cmd/stream-share/command_provider_share.go

0a1c9fa

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider.go

f295703

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

Update internal/cmd/stream-share/command_provider_share.go

ac2c264

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

format imports

00af753

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 4, 2022 19:20

switched over to cdx public sdk

b5d0264

Brian Strauch (brianstrauch) reviewed Aug 5, 2022

View reviewed changes

internal/cmd/stream-share/command_provider.go Outdated Show resolved Hide resolved

internal/cmd/stream-share/command_provider_share_describe.go Outdated Show resolved Hide resolved

internal/cmd/stream-share/command_provider_share_describe.go Outdated Show resolved Hide resolved

Sumit Tokkar (stkr89) and others added 3 commits August 5, 2022 13:04

Update internal/cmd/stream-share/command_provider_share_describe.go

0aca0da

Co-authored-by: Brian Strauch <bstrauch@confluent.io>

reformat code

6affa01

Merge branch 'stokkar/CDX-386-add-cli-commands-for-provider-consumer-…

bfc28d4

…shared-resources' of github.com:confluentinc/cli into stokkar/CDX-386-add-cli-commands-for-provider-consumer-shared-resources

Sumit Tokkar (stkr89) requested a review from Brian Strauch (brianstrauch) August 5, 2022 18:12

Brian Strauch (brianstrauch) approved these changes Aug 5, 2022

View reviewed changes

Sumit Tokkar (stkr89) merged commit 6d87727 into main Aug 5, 2022

Sumit Tokkar (stkr89) deleted the stokkar/CDX-386-add-cli-commands-for-provider-consumer-shared-resources branch August 5, 2022 19:26

Brian Strauch (brianstrauch) mentioned this pull request Aug 16, 2022

Fix make docs #1401

Merged

Conversation

Sumit Tokkar (stkr89) commented Jul 19, 2022

Checklist

What

References

Test & Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sumit Tokkar (stkr89) commented Jul 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brian Strauch (brianstrauch) commented Jul 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants