Merged
Conversation
David Hyde (DABH)
approved these changes
Aug 16, 2022
Contributor
|
CI issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
What
#1367 broke
make docs, since it would fetch and cache the feature flag. This PR assumes that formake docs,make lint,make update-whitelist, etc. all feature flags are enabled, so no flags need to be fetched or cached.In the future, I'd like to improve how feature flags work (and get rid of dynamic configs/contexts, which was the source of this bug and many others), but this PR is just to unblock the team and this week's release.
References
https://confluent.slack.com/archives/CG6BW233L/p1660606154337109
Test & Review
Manually verified that
maketargets work as intended.