Skip to content

Fix make docs #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brian Strauch (brianstrauch) merged 2 commits into from
Aug 16, 2022
Merged

Fix make docs #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7234a8b
fix make docs
Aug 16, 2022
700adc9
fix integration tests
Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/docs/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func main() {
for i, cfg := range configs {
tabs[i] = docs.Tab{
Name: cfg.CurrentContext,
Command: cmd.NewConfluentCommand(cfg, new(version.Version), false),
Command: cmd.NewConfluentCommand(cfg, new(version.Version), true),
}
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/usage/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func buildWhitelist() []string {
{CurrentContext: "On-Prem", Contexts: map[string]*v1.Context{"On-Prem": {PlatformName: "https://example.com"}}},
}
for _, cfg := range configs {
cmd := pcmd.NewConfluentCommand(cfg, new(pversion.Version), false)
cmd := pcmd.NewConfluentCommand(cfg, new(pversion.Version), true)
usage.WhitelistCommandsAndFlags(cmd, whitelist)
}

Expand Down
7 changes: 2 additions & 5 deletions internal/cmd/stream-share/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,14 @@ type command struct {
}

func New(cfg *v1.Config, prerunner pcmd.PreRunner) *cobra.Command {
dynamicCtx := dynamicconfig.NewDynamicContext(cfg.Context(), nil, nil)
ctx := dynamicconfig.NewDynamicContext(cfg.Context(), nil, nil)

cmd := &cobra.Command{
Use: "stream-share",
Aliases: []string{"ss"},
Short: "Manage stream shares.",
Annotations: map[string]string{pcmd.RunRequirement: pcmd.RequireCloudLogin},
}

if !featureflags.Manager.BoolVariation("cli.cdx", dynamicCtx, v1.CliLaunchDarklyClient, true, false) {
cmd.Hidden = true
Hidden: !cfg.IsTest && !featureflags.Manager.BoolVariation("cli.cdx", ctx, v1.CliLaunchDarklyClient, true, false),
}

c := &command{pcmd.NewAuthenticatedCLICommand(cmd, prerunner)}
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/output/help/cloud-windows.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Available Commands:
schema-registry Manage Schema Registry.
service-quota Look up Confluent Cloud service quota limits.
shell Start an interactive shell.
stream-share Manage stream shares.
update Update the Confluent CLI.
version Show version of the Confluent CLI.

Expand Down
1 change: 1 addition & 0 deletions test/fixtures/output/help/cloud.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Available Commands:
schema-registry Manage Schema Registry.
service-quota Look up Confluent Cloud service quota limits.
shell Start an interactive shell.
stream-share Manage stream shares.
update Update the Confluent CLI.
version Show version of the Confluent CLI.

Expand Down