[ORC- 8867]feat: add confluent-jdbc connection #3092
[ORC- 8867]feat: add confluent-jdbc connection #3092rveerannagowda (rveerannagowda) merged 9 commits intomainfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces "confluent-jdbc" as a new Flink connection type for Confluent Cloud. Key changes include:
- Adding test cases in test/flink_test.go for the new connection type.
- Updating golden files for connection help, list, and error messages to include "confluent-jdbc".
- Modifying connection type mappings in pkg/flink/utils.go and vocabulary in cmd/lint/main.go.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/flink_test.go | Added test case for creating a confluent-jdbc connection. |
| test/fixtures/output/flink/connection/update-help.golden | Updated help text to include confluent-jdbc username/password. |
| test/fixtures/output/flink/connection/list/*.golden | Updated list and error messages to include confluent-jdbc. |
| test/fixtures/output/flink/connection/create/*.golden | Added golden output for confluent-jdbc connection creation. |
| pkg/flink/utils.go | Extended connection type arrays and mappings for confluent-jdbc. |
| cmd/lint/main.go | Included confluent-jdbc into the allowed vocabulary. |
This comment has been minimized.
This comment has been minimized.
Flaky test unrelated to code failing :https://confluent.slack.com/archives/CG6BW233L/p1738097461887909 |
| --password string Specify password for the type: "mongodb" or "couchbase". | ||
| --username string Specify username for the type: "mongodb", "couchbase", or "confluent-jdbc". | ||
| --password string Specify password for the type: "mongodb", "couchbase", or "confluent-jdbc". | ||
| --auth string Specify auth for the type: "confluent-jdbc". |
There was a problem hiding this comment.
Why do we need auth? Is username, password not enough?
There was a problem hiding this comment.
confluent flink connection create mysql_customer_db
--cloud aws --region us-east-2 --environment env-o2zynj
--type confluent-jdbc
--endpoint 'jdbc:mysql://customer-db.example.com:3306/customerdb'
--auth basic
--username 'readonly_user'
--password 'secret123'
I was trying to follow whats the command line is there in the product doc .Have added auth as optional and username and password as required
There was a problem hiding this comment.
I do not think we need auth now as we have not decided on private network approach yet, maybe we can add them later.
There was a problem hiding this comment.
Thanks for the clarification ! Removed it
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
The overall PR looks great! We should add more results to testing section though, such as creating a connection maybe? Also, the release notes are customer facing and should be precise.Please refer to release notes of other CLI PRs for reference. |
Release Notes
New Features
confluent-jdbc.Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Add confluent-jdbc as a new flink connection type for Confluent Cloud.
Blast Radius
Confluent Platform customers using
confluent flink connectionsubcommand would be affectedReferences
JIRA ticket: https://confluentinc.atlassian.net/browse/ORC-8867
Test & Review
Creating connection of type confluent-jdbc
Listing Connections of type confluent-jdbc
Updating Connection :
Deleting Connection