Revert "[ORC-8867] update connection name"#3095
Merged
tmalik (tmalikconfluent) merged 1 commit intomainfrom May 15, 2025
Merged
Revert "[ORC-8867] update connection name"#3095tmalik (tmalikconfluent) merged 1 commit intomainfrom
tmalik (tmalikconfluent) merged 1 commit intomainfrom
Conversation
This reverts commit 4bb1549. Revert "update" This reverts commit 061d284. Revert "Test" This reverts commit e8a620c. Revert "Add auth type optional argument" This reverts commit 688342b. Revert "Update to fix tests" This reverts commit 549f096. Revert "update" This reverts commit f163c31. Revert "update the tests" This reverts commit dac9be3. Revert "Remove optional auth arg" This reverts commit eeddc6c. Revert "Remove auth arg from flink test" This reverts commit a67d82d.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in ORC-8867 by removing the references to the "confluent-jdbc" connection type. The changes include the removal of test cases, updates to help text and error messages, and modifications to internal connection type mappings and lint vocabulary.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/flink_test.go | Removed test case for creating a "confluent-jdbc" connection |
| test/fixtures/output/flink/connection/update-help.golden | Updated help text to remove the "confluent-jdbc" username and password options |
| test/fixtures/output/flink/connection/list-failure.golden | Adjusted the suggestions list by removing "confluent-jdbc" |
| test/fixtures/output/flink/connection/list-help.golden | Revised connection type help message to no longer reference "confluent-jdbc" |
| test/fixtures/output/flink/connection/create/create-wrong-type.golden | Adjusted error suggestion by removing "confluent-jdbc" |
| test/fixtures/output/flink/connection/create/create-confluent_jdbc.golden | Removed obsolete golden file for "confluent-jdbc" creation |
| test/fixtures/output/flink/connection/create-help.golden | Updated the help message to reflect the changed supported connection types |
| pkg/flink/utils.go | Removed "confluent-jdbc" from the connection types and corresponding mappings |
| cmd/lint/main.go | Removed "confluent-jdbc" and "jdbc" entries from lint vocabulary |
Analysis Details0 Issues
Coverage and Duplications
Project ID: cli |
Steven Gagniere (sgagniere)
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Breaking Changes
New Features
Bug Fixes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Revert ORC-8867 for release
Blast Radius
N/A
References
Original PR - #3092
Test & Review
make build works