Skip to content

Add filter on "connect list" by account_id/name/etc - #7

Merged
Cody A. Ray (codyaray) merged 1 commit into
masterfrom
filter-list
May 10, 2018
Merged

Add filter on "connect list" by account_id/name/etc#7
Cody A. Ray (codyaray) merged 1 commit into
masterfrom
filter-list

Conversation

@codyaray

@codyaray Cody A. Ray (codyaray) commented May 10, 2018

Copy link
Copy Markdown
Contributor

@confluentinc/caas

And centralize login/account_id checking & injection from plugin to cmd package

@codyaray
Cody A. Ray (codyaray) requested a review from a team May 10, 2018 14:46
@codyaray
Cody A. Ray (codyaray) merged commit 3f5cd54 into master May 10, 2018
@codyaray
Cody A. Ray (codyaray) deleted the filter-list branch May 10, 2018 14:59
@codyaray
Cody A. Ray (codyaray) restored the filter-list branch May 10, 2018 15:21
Comment thread command/common/cli.go
}

func CheckLogin(config *shared.Config) error {
if config == nil || config.Auth == nil || config.Auth.Account == nil || config.Auth.Account.Id == "" {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should've been a method on the config

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair. i'll do it as a follow-up

@norwood
dan norwood (norwood) deleted the filter-list branch February 14, 2019 18:26
Brian Strauch (brianstrauch) pushed a commit that referenced this pull request May 31, 2023
* feat: add main go with go-prompt example + custom shortcut

* docs: add readme

* feat: add tview examples

* feat: remove code and display two components at the same time

* feat: add basic folder structure

* feat: fix ui formatting / allow text on input

* feat: try changing focus/navigating between table and input

* feat: esc/enter to switch between input and table

* feat: move main and create components package

* feat: add go-prompt before initializing tview

* feat: format input color

* feat: add shortcuts text view for shortcuts

* feat: add toggle display mode with shortcuts

* feat: comment out stuff that needs to be refactored

* docs: complement readme with infos

* docs: add considerations to readme

* refactor: removed unused file

* refactor: some refactor on main file

* build: fix make test

* build: add vscode debugger settings

* chore: update goenv version to 1.19.2

Otherwise when semaphore installs 1.19.2
but goenv looks for 1.19.0 go mod will fail

Co-authored-by: Tomasz Nguyen <tonguyen@confluent.io>
airlock-confluentinc Bot pushed a commit that referenced this pull request Sep 4, 2024
* chore: stop swallowing error when LSP client fails to be initialized (#136)

* flink statement resume

* flink statement update

* fix tests

* list compute pool flag first

* updated with revised plan

* fix tests

* rebase

* rebase test working

* Revert Last change

* Formatiing

* Failing test case

* Test Cases fix

* Lint

* Lint test case

---------

Co-authored-by: Yannick Pferr <37211050+YannickPferr@users.noreply.github.com>
Co-authored-by: Brian Strauch <bstrauch@confluent.io>
Co-authored-by: Tushar Malik <tmalik@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants