Skip to content

Add support to terminate the pod without the announcement to repro the node termination issues if required #341

Merged
Rushikesh Bankar (rbankar7) merged 12 commits into30.0.1-confluentfrom
rban/repro-ungraceful-termination
Jun 4, 2025
Merged

Add support to terminate the pod without the announcement to repro the node termination issues if required #341
Rushikesh Bankar (rbankar7) merged 12 commits into30.0.1-confluentfrom
rban/repro-ungraceful-termination

Conversation

@rbankar7
Copy link
Copy Markdown
Member

@rbankar7 Rushikesh Bankar (rbankar7) commented Jun 3, 2025

Description

  • Add support to terminate the pod without the announcement to reproduce the node termination issues
  • When we enable the system property -Ddruid.lifecycle.ungracefulShutDownWaitTimeExperimental=30 this would repro the issue of node not ready in the druid cluster and we would be able to test our fix

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

For tips about how to write a good release note, see Release notes.


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@rbankar7 Rushikesh Bankar (rbankar7) changed the title Rban/repro ungraceful termination Add support to terminate the pod without the announcement to repro the node termination issues if required and increase frequency for periodicListExecutor Jun 3, 2025
@rbankar7 Rushikesh Bankar (rbankar7) marked this pull request as ready for review June 3, 2025 11:19
@rbankar7 Rushikesh Bankar (rbankar7) requested a review from a team as a code owner June 3, 2025 11:19
@rbankar7 Rushikesh Bankar (rbankar7) changed the title Add support to terminate the pod without the announcement to repro the node termination issues if required and increase frequency for periodicListExecutor Add support to terminate the pod without the announcement to repro the node termination issues if required Jun 3, 2025
@airlock-confluentinc airlock-confluentinc Bot force-pushed the rban/repro-ungraceful-termination branch from 032086c to 2d9cc8b Compare June 3, 2025 19:23
@rbankar7 Rushikesh Bankar (rbankar7) merged commit 4d8d7cb into 30.0.1-confluent Jun 4, 2025
2 checks passed
@rbankar7 Rushikesh Bankar (rbankar7) deleted the rban/repro-ungraceful-termination branch June 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants