Skip to content

Revert changes from the lifecycle added for the abrupt termination#343

Merged
Rushikesh Bankar (rbankar7) merged 1 commit into30.0.1-confluentfrom
rban/revert-ungraceful-termination
Jun 7, 2025
Merged

Revert changes from the lifecycle added for the abrupt termination#343
Rushikesh Bankar (rbankar7) merged 1 commit into30.0.1-confluentfrom
rban/revert-ungraceful-termination

Conversation

@rbankar7
Copy link
Copy Markdown
Member

@rbankar7 Rushikesh Bankar (rbankar7) commented Jun 7, 2025

reverts changes in the lifecycle added by the PR- #341

Description

  • The changes were added to make the termination ungraceful when we set the system property druid.lifecycle.ungracefulShutDownWaitTimeExperimental
  • But it is not needed now as we have finished our testing

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@rbankar7 Rushikesh Bankar (rbankar7) marked this pull request as ready for review June 7, 2025 09:00
@rbankar7 Rushikesh Bankar (rbankar7) requested a review from a team as a code owner June 7, 2025 09:00
@rbankar7 Rushikesh Bankar (rbankar7) merged commit 40d2d9e into 30.0.1-confluent Jun 7, 2025
2 checks passed
@rbankar7 Rushikesh Bankar (rbankar7) deleted the rban/revert-ungraceful-termination branch June 7, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants