Skip to content

Remove boolean and floats from supported key types #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Remove boolean and floats from supported key types #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/main/java/io/confluent/connect/elasticsearch/DataConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,13 @@ public static String convertKey(Object key, Schema keySchema) {
}

switch (schemaType) {
case BOOLEAN:
case INT8:
case INT16:
case INT32:
case INT64:
case FLOAT32:
case FLOAT64:
case STRING:
return String.valueOf(key);
default:
// TODO: support more key types, also should we support BOOLEAN and FLOAT at all?
throw new DataException(schemaType.name() + "is not supported as the document id.");
}
}
Expand Down