Major refactor: Package restructure - #271
Closed
Antony Stubbs (astubbs) wants to merge 6 commits into
Closed
Conversation
- Removes onPartitionsLost handlers as we don't need to do anything differently than from onPartitionsRevoked
| * Copyright (C) 2020-2022 Confluent, Inc. | ||
| */ | ||
|
|
||
| public class Message { |
Contributor
Author
There was a problem hiding this comment.
docs
| long highestSucceeded = partitionState.getOffsetHighestSucceeded(); | ||
| byte[] encodeOffsetsCompressed(long finalOffsetForPartition, HighestOffsetAndIncompletes partitionState) throws NoEncodingPossibleException { | ||
| var incompleteOffsets = partitionState.getIncompleteOffsets(); | ||
| //long highestSucceeded = partitionState.getOffsetHighestSucceeded(); |
Contributor
Author
There was a problem hiding this comment.
remove
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| @Value |
Contributor
Author
There was a problem hiding this comment.
docs
| * Commit request message | ||
| */ | ||
| @Value | ||
| public class CommitRequest { |
Contributor
Author
There was a problem hiding this comment.
extend
| * Commit response message, linked to a {@link CommitRequest} | ||
| */ | ||
| @Value | ||
| public class CommitResponse { |
Contributor
Author
There was a problem hiding this comment.
extend
| @RequiredArgsConstructor(access = PRIVATE) | ||
| @Getter | ||
| @EqualsAndHashCode | ||
| public class ControllerEventMessage<K, V> { |
Contributor
Author
There was a problem hiding this comment.
extend
| import java.util.Collection; | ||
|
|
||
| @Value | ||
| public class PartitionEventMessage { |
Contributor
Author
There was a problem hiding this comment.
extend
| log.debug("Vert.x Vertical success"); | ||
| wc.onUserFunctionSuccess(); | ||
| addToMailbox(wc); | ||
| super.bus.sendWorkResultEvent(wc); |
Contributor
Author
There was a problem hiding this comment.
implement delegate for add to mb
This was referenced May 6, 2022
Antony Stubbs (astubbs)
changed the title
Contributor
|
Closing - Stale. |
This was referenced Aug 5, 2026
Antony Stubbs (astubbs)
added a commit
to astubbs/parallel-consumer
that referenced
this pull request
Aug 6, 2026
Master's 735b1d3 mirrored all 78 confluentinc issues into this fork, which made a bare `#NN` ambiguous: the fork numbers from 1 and confluentinc reaches confluentinc#922, so the ranges overlap completely. The house convention is now `#159` / `confluentinc#526`, and `.github/scripts/issue-ref-gate.js` enforces it on added lines via the PR Checklist job. This branch predates that and had 15 unqualified refs across three files - `#159`, `#40`, `#202`, `#206`, `#162`, `confluentinc#861`, `confluentinc#526`, `confluentinc#271`. Every one is now qualified. Verified by running the gate module itself over this branch's diff rather than by eye: 15 findings -> 0. `upstream #NNN` is still accepted by the gate, but converted anyway - "upstream" names a role rather than a repo, and this repo is upstream to anyone who forks it, which is why master moved off it. No wording changed beyond the references themselves, except the in-flight note, which now also records that #159 IS the upstream-mirror issue for confluentinc#526 - that is where the fork<->upstream mapping lives now that the map entry is gone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RtNUsxokE9g2pSEjBHZqNA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description...
Checklist