Skip to content

Fix Konflux build platform arch (main branch)#1696

Merged
simonbaird merged 1 commit intoconforma:mainfrom
simonbaird:fix-goos-gooarch-for-konflux-builds
Jun 13, 2024
Merged

Fix Konflux build platform arch (main branch)#1696
simonbaird merged 1 commit intoconforma:mainfrom
simonbaird:fix-goos-gooarch-for-konflux-builds

Conversation

@simonbaird
Copy link
Copy Markdown
Member

The GOOS and GOARCH env vars need to be set explicitly, otherwise we just build the linux x86 binary over and over. Looks like this regression was introduced in commit b8db99c.

I think restoring the export on those two vars would also have worked.

Ref: https://issues.redhat.com/browse/SECURESIGN-1054

The GOOS and GOARCH env vars need to be set explicitly, otherwise we
just build the linux x86 binary over and over. Looks like this
regression was introduced in commit b8db99c.

I think restoring the export on those two vars would also have
worked.

Ref: https://issues.redhat.com/browse/SECURESIGN-1054
@simonbaird simonbaird changed the title Fix Konflux build platform arch Fix Konflux build platform arch (main branch) Jun 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (3f31ea4) to head (d62ea87).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
+ Coverage   80.01%   86.66%   +6.64%     
==========================================
  Files          65       76      +11     
  Lines        4818     5158     +340     
==========================================
+ Hits         3855     4470     +615     
+ Misses        963      688     -275     
Flag Coverage Δ
acceptance 71.77% <ø> (?)
generative 80.01% <ø> (ø)
integration 80.01% <ø> (ø)
unit 80.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

@simonbaird simonbaird merged commit 6aee3bf into conforma:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant