Fix Konflux build platform arch (release-v0.4 branch)#1697
Merged
simonbaird merged 1 commit intoconforma:release-v0.4from Jun 13, 2024
Merged
Conversation
The GOOS and GOARCH env vars need to be set explicitly, otherwise we just build the linux x86 binary over and over. Looks like this regression was introduced in commit b8db99c. I think restoring the export on those two vars would also have worked. Ref: https://issues.redhat.com/browse/SECURESIGN-1054 (cherry picked to release-v0.4 branch from main branch commit d62ea87)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.4 #1697 +/- ##
================================================
+ Coverage 80.01% 86.66% +6.64%
================================================
Files 65 76 +11
Lines 4818 5158 +340
================================================
+ Hits 3855 4470 +615
+ Misses 963 688 -275
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
The pre-merge build only creates one binary, so we'll need to wait for the post-merge build to double check it's doing the right thing. But I did test it locally and it seems to be working as expected. |
simonbaird
added a commit
to simonbaird/securesign-cosign
that referenced
this pull request
Jun 13, 2024
The ec version is v0.4.79+redhat built on sha 9faa387. The image is identical to registry.redhat.io/rhtas/ec-rhel9:0.4-1718293643 . Should resolve SECURESIGN-1054. See also conforma/cli#1697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GOOS and GOARCH env vars need to be set explicitly, otherwise we just build the linux x86 binary over and over. Looks like this regression was introduced in commit b8db99c.
I think restoring the export on those two vars would also have worked.
Ref: https://issues.redhat.com/browse/SECURESIGN-1054
(cherry picked to release-v0.4 branch from main branch commit d62ea87)
This is the release branch version of #1696.