Add exec channel request support (RFC 4254 §6.5)#95
Merged
Conversation
kruton
approved these changes
Apr 3, 2026
Member
|
You also have to run |
kruton
requested changes
Apr 3, 2026
kruton
left a comment
Member
There was a problem hiding this comment.
Run ./gradlew metalavaGenerateSignature
Add requestExec(command) to SshSession interface and SessionChannel implementation, following the same pattern as requestShell(). This enables remote command execution on session channels. Integration tests verify stdout and stderr output from executed commands.
Contributor
Author
|
Done — ran |
kruton
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
requestExec(command: String): Booleanto theSshSessioninterface andSessionChannelimplementation, enabling remote command execution on session channels.requestShell()— usessendChannelRequest("exec", ...)with the existingChannelRequestExecKaitai definitionrequestShell,requestExec, or subsystem requests may succeed per session channel (per RFC 4254 §6.5)Changes
SshSession.kt— addedrequestExec(command: String): Booleanto the interfaceSessionChannel.kt— implementation usingChannelRequestExecprotocol messageSshClientIntegrationTest.kt— two integration tests:Test plan
./gradlew :sshlib:test— integration tests pass against OpenSSH testcontainerecho hello-exec)echo error-output >&2)