Push the latest contracts#516
Merged
Merged
Conversation
Co-authored-by: raulk <raul@protocol.ai>
Signed-off-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: snissn <snissn@users.noreply.github.com> Co-authored-by: auto-commit <auto-commit@users.noreply.github.com> Co-authored-by: Alfonso de la Rocha <adlrocha@tutamail.com> Co-authored-by: adlrocha <adlrocha@users.noreply.github.com> Co-authored-by: raulk <raul.kripalani@gmail.com> Co-authored-by: raulk <raul@protocol.ai>
Split Subnet Actor manager
This PR establishes a skeleton for future invariant tests for GatewayActor. The main idea is to define all basic properties of the gatewayActor and be able to apply them to many different Gateway instances with different configurations.
raulk
requested changes
Jan 8, 2024
raulk
left a comment
raulk
left a comment
Contributor
There was a problem hiding this comment.
Can you use the instructions in the README to absorb the commit history from the original repo instead?
dnkolegov
force-pushed
the
update_contracts
branch
from
January 8, 2024 15:10
f4feb8e to
4854744
Compare
Contributor
Author
Done. |
raulk
reviewed
Jan 8, 2024
| @@ -0,0 +1,44 @@ | |||
| name: Build and Test Workflow | |||
Contributor
There was a problem hiding this comment.
This should be integrated in the repo's GitHub workflows.
Contributor
There was a problem hiding this comment.
We'll move this file to a top-level dir, but it's fine here for now.
Contributor
There was a problem hiding this comment.
We'll move this file to a top-level dir, but it's fine here for now.
maciejwitowski
approved these changes
Jan 10, 2024
aakoshh
reviewed
Jan 10, 2024
Comment on lines
+63
to
+64
| s.SUBNET_ACTOR_CHECKPOINTING_FACET = params.checkpointerFacet; | ||
| s.SUBNET_ACTOR_PAUSE_FACET = params.pauserFacet; |
Contributor
There was a problem hiding this comment.
Just noting the different words, PAUSE vs pauser, CHECKPOINTING vs checkpointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push the latest contracts from the upstream and update the code that calls the contracts.