feat: add is_dumb public function#290
Merged
Merged
Conversation
djc
reviewed
Jul 1, 2026
ugur-eren
force-pushed
the
feat/add-is-dumb-public-function
branch
from
9bfbab6 to
ad100af
Compare
Member
|
Can you squash your existing commits and add a version bump commit? |
djc
approved these changes
Jul 1, 2026
Contributor
Author
Should I increase patch or minor? Sorry, I don't know how cargo treats pre-1.0 releases. |
Member
No worries. It should be 0.16.4, since this PR does not make any semver-incompatible changes. If this crate was post-1.0.0 we'd increase the minor version because the new API is a forward compatibility hazard. |
ugur-eren
force-pushed
the
feat/add-is-dumb-public-function
branch
from
ad100af to
86aafb0
Compare
Member
|
Published 0.16.4, thanks! |
kodiakhq Bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jul 2, 2026
Bumps console from 0.16.3 to 0.16.4. Release notes Sourced from console's releases. 0.16.4 What's Changed chore: Remove redudant helper and add TermInner constructors by @ChrisDenton in console-rs/console#284 Style::from_dotted_str ignore non-ascii by @danjl1100 in console-rs/console#287 feat: add is_dumb public function by @ugur-eren in console-rs/console#290 Commits 598eca9 Bump version to 0.16.4 0f22c35 feat: add is_dumb public function 1426649 Bump actions/checkout from 3 to 7 d2d89ad ignore non-ascii input in Style::from_dotted_str 6cff3e0 document current panic in Style::from_dotted_str via test cases dd4334f Apply suggestions from clippy 1.95 586efad Remove redundant as_handle helper be20e85 Add TermInner::new constructors See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add public
is_dumb()functionExposes a new public function
is_dumb()that provides a fast way to check whether the application has a "dumb" terminal (i.e.TERMis unset or set todumbon Unix;TERMexplicitly set todumbon Windows).This logic previously existed only as an inline check inside
is_a_color_terminal(). This PR extracts it into a dedicatedis_a_dumb_terminal()function per platform (unix_term.rs,windows_term/mod.rs,wasm_term.rs), and wires it up through a new publicis_dumb()interm.rs, re-exported fromlib.rs.Behavior
No change to existing
is_a_color_terminal()output. This is a pure refactor for that path. New behavior is only the addition of the standaloneis_dumb()API.Note
is_dumb()semantics differ slightly by platform whenTERMis unset (Unix treats unset as dumb but Windows does not, since native Windows terminals typically don't setTERM).This is intentional and documented on the function.
This PR is in relation to conversation on PR console-rs/indicatif#808