Paint project-pane token meter cells as background, not █ - #1212
Merged
Conversation
The fleet meter fixed hairline row seams by painting full cells as background (#1183). The project dashboard kept a simplified path that still used FULL BLOCK glyphs, so the same brick seams showed there. Move column paint helpers into token_meter and use them for both meters so solid bars stay solid on every font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
█glyph (Paint solid token-meter cells as background, not as a block glyph #1183), so fonts with a short FULL BLOCK do not leave hairline panel seams between rows.█, so the same brick-seam artifact showed on that graph.column_cells,band_cell,stacked_eighths) intotoken_meterand render both meters through them.Testing
cargo test -p construct-cli token_meter— 40 tests passed (includingcolumn_cells_paint_whole_cells_as_backgroundand the rest of the paint suite).No vhs pair: same as #1183, vhs's font draws FULL BLOCK filling the line box, so before/after would look identical.