Stop dumping a tunnel QR + scan banner into the daemon log#282
Merged
Conversation
Every time the cloudflared tunnel comes up the daemon was writing a full-screen QR code plus a "scan to open in a mobile client" line to stdout via `println!`. That clobbers terminal scrollback on every restart and isn't necessary: the same QR is already rendered in the TUI's `/remote-control` modal and in the webui, and the structured `tracing::info!` line immediately after the call logs both the `browser` and `wss` URLs. Drop the `print_qr` call and the now-unused helper. The QR renderer itself (`render_qr_dense1x2`) stays because the IPC paths that serve the modal still use it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every time the cloudflared tunnel comes up (on daemon start, on
remote-controlenable, on reconnect), the daemon writes a full-screen QR code plus ascan to open in a mobile client:line directly to stdout viaprintln!. That clobbers terminal scrollback on every restart for anyone runningagentdin the foreground or tailing its log.It isn't necessary: the same QR is already rendered in the TUI's
/remote-controlmodal (crates/cli/src/ui.rs:5785) and in the webui, and the structuredtracing::info!line immediately below the call already logs both thebrowserandwssURLs — sotail -f/journalctlstill surface where the tunnel landed.Fix
Drop the
print_qrcall and the now-unused helper (crates/daemon/src/tunnel.rs). The QR renderer itself (render_qr_dense1x2) stays — the IPC paths that feed the TUI/webui modal still use it (crates/daemon/src/session.rs:1002,1014,1035).Test
🤖 Generated with Claude Code