Lazy-load older PTY replay in web UI#292
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_bytes/before_offsetparams to PTY replayTests
cargo test -p agentd pty_range_before_returns_offsets_and_requested_slicecargo test -p agentd pty_range_before_clamps_to_file_start_and_endcargo test -p agentd pty_replay_returns_full_disk_tail_not_just_old_ringcargo test -p agentd pty_replay_caps_at_replay_max_for_huge_logscargo check -p agentdcargo buildgit diff --checkBinaries
Built in this worktree under
/Users/moon/agentd/.claude/worktrees/webui-lazy-pty-replay/target/debug/.Relevant binary for this PR:
agentd(crates/daemon, protocol + embedded Web UI assets).