Preserve spacing in Codex scrollback snapshots#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves meaningful blank rows in Codex/PTY shadow scrollback snapshots.
Before this change, the shadow snapshot path dropped every empty row before appending a repaint frame into scrollback. Older Codex pages therefore looked like a compact list of text, with visual spacing between user/assistant/tool sections collapsed.
Now the snapshot path:
Testing
cargo test -p agentd-cli codex_shadow_snapshot_preserves_internal_blank_rows -- --nocapturecargo test -p agentd-cli codex_scrollback -- --nocapturecargo test -p agentd-cli codex_pure_tui_redraw_scrollback_exposes_older_frames -- --nocapturecargo check -p agentd-clicargo buildgit diff --check