Skip to content

Preserve spacing in Codex scrollback snapshots#306

Merged
edwin-zvs merged 2 commits into
mainfrom
codex-scrollback-spacing
May 31, 2026
Merged

Preserve spacing in Codex scrollback snapshots#306
edwin-zvs merged 2 commits into
mainfrom
codex-scrollback-spacing

Conversation

@edwin-zvs

Copy link
Copy Markdown
Contributor

Summary

Preserves meaningful blank rows in Codex/PTY shadow scrollback snapshots.

Before this change, the shadow snapshot path dropped every empty row before appending a repaint frame into scrollback. Older Codex pages therefore looked like a compact list of text, with visual spacing between user/assistant/tool sections collapsed.

Now the snapshot path:

  • records text rows and internal blank rows,
  • trims only leading/trailing blank padding,
  • keeps duplicate snapshot detection intact.

Testing

  • cargo test -p agentd-cli codex_shadow_snapshot_preserves_internal_blank_rows -- --nocapture
  • cargo test -p agentd-cli codex_scrollback -- --nocapture
  • cargo test -p agentd-cli codex_pure_tui_redraw_scrollback_exposes_older_frames -- --nocapture
  • cargo check -p agentd-cli
  • cargo build
  • git diff --check

@edwin-zvs
edwin-zvs merged commit 613c527 into main May 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant